Bug 648008 – =net-misc/radvd-2.17-r1 with =sys-libs/musl=1.1.18 and =sys-kernel/linux-headers-4.15::musl - (no error message?)

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Fabio Scaccabarozzi 2018-02-18 13:47:29 UTC]

As per subject, package fails to compile, because inclusion guards in inclusions.h header are not correct.

Reproducible: Always

Steps to Reproduce:
emerge -1 =net-misc/radvd-2.17-r1 on a system with =sys-libs/musl-1.1.18 and =sys-kernel/linux-headers-4.15::musl



In inclusions.h:
- net/if_arp.h is included only if there is no linux/if_arp.h (line 89)
- then, linux/if_arp.h gets included if it's present, regardless of any other includes (line 105)

Problem is that at line 79 net/if.h is included, and that already defines things that are defined in linux/if.h, which is pulled in by linux/if_arp.h (courtesy of "#include linux/netdevice.h").
Note that net/if.h is assumed to exist and is included unconditionally.

Attached patch makes the package compile by making net/if_arp.h preferred include:
- remove exclusion if linux/if_arp.h is present (line 89)
- include linux/if_arp.h only if net/if_arp.h is missing (line 105)

* Did not test package
* patch still makes package compile properly with =sys-libs/glibc-2.26-r6, =sys-kernel/linux-headers-4.15::gentoo

[Comment 1 Fabio Scaccabarozzi 2018-02-18 13:49:06 UTC]

Created attachment 520022 [details, diff]
Patch to make net/if_arp.h preferred include over linux/if_arp.h

[Comment 2 Felix Janda 2018-02-18 14:55:35 UTC]

It works fine for me (without any patch), if I use
sys-kernel/linux-headers-4.15::gentoo and apply the following upstream
patch to sys-devel/musl-1.18:

http://git.musl-libc.org/cgit/musl/commit/?id=b583c5d3b4cc2c54c68eef5eb7855ecfacee8bfc

So this bug might become obsolete once musl 1.19 comes out.

[Comment 3 Fabio Scaccabarozzi 2018-02-19 06:01:21 UTC]

Created attachment 520082 [details]
Failing ebuild log

@Felix: understood, I don't want to break my current chroot, will wait to resume work on musl then, thanks :-)

@all: Sorry, completely forgot to attach the ebuild log for reference.
Also see below emerge --info package report:
-----------------
~ # emerge --info
Portage 2.3.24 (python 3.5.4-final-0, default/linux/musl/amd64, gcc-7.3.0, musl-1.1.18, 4.15.2 x86_64)
=================================================================
System uname: Linux-4.15.2-x86_64-Intel-R-_Core-TM-_i7-6700HQ_CPU_@_2.60GHz-with-gentoo-2.4.1
KiB Mem:    16323672 total,  12701164 free
KiB Swap:   33554428 total,  33554428 free
Timestamp of repository gentoo: Sun, 18 Feb 2018 22:06:41 +0000
Head commit of repository gentoo: c387406d66569ad0d35fa60133e1d839917e44c8

Head commit of repository musl: 094d692a0f13288cc92da2f86dd70b8a2efff35f

Head commit of repository steam-overlay: 46d2624c5f248bf28e25c25e172e60c2eb988e5f

Head commit of repository x11: 258c9162a836a54f9d5bc6a459787ab301591a7b

sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
app-shells/bash:          4.4_p12::gentoo
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.4.5-r1::gentoo, 3.5.4-r1::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.12::musl
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.15.1-r1::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo
sys-devel/gcc:            7.3.0::musl
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.15::musl (virtual/os-headers)
sys-libs/musl:            1.1.18::gentoo

[Comment 4 Sergei Trofimovich (RETIRED) 2018-11-25 11:29:24 UTC]

Should work on modern stable versions of musl and linux-headers.