Summary: | app-misc/dejsonlz4-1.1 - Decompress Mozilla Firefox bookmarks backup files | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | thyr |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | kripton, thyr |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/avih/dejsonlz4/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
dejsonlz4-1.1.ebuild
dejsonlz4-1.1.ebuild: fixed SRC_URI; src_compile added |
Description
thyr
2018-02-10 01:05:01 UTC
Comment on attachment 518882 [details] dejsonlz4-1.1.ebuild ># Copyright 1999-2018 Gentoo Foundation ># Distributed under the terms of the GNU General Public License v2 > >EAPI=6 > >DESCRIPTION="Decompress Mozilla Firefox bookmarks backup files" >HOMEPAGE="https://github.com/avih/dejsonlz4/" >SRC_URI="https://github.com/avih/dejsonlz4/archive/v1.1.zip" If every ebuild did this, DISTDIR would be full of things named "v{version}.zip". We instead use redirects that looks like this: https://github.com/avih/dejsonlz4/archive/v1.1.zip -> ${P}.zip where ${P} stands for ${PN}-${PV} and where ${PN} is the package name and where ${PV} is the package version. > >LICENSE="BSD-2" >SLOT="0" >KEYWORDS="~amd64 ~x86" > >src_install() { This is the build phase where you install things. > gcc -Wall -o dejsonlz4 src/dejsonlz4.c src/lz4.c The build phase that compiles things is src_compile() not src_install(). Your ebuild should respect the compiler executable set in the CC variable instead of hard-coding "gcc". Your ebuild should use the compiler flags set in the CFLAGS variable. > dobin dejsonlz4 >} Created attachment 519126 [details]
dejsonlz4-1.1.ebuild: fixed SRC_URI; src_compile added
(In reply to Jeroen Roovers from comment #1) > Comment on attachment 518882 [details] > dejsonlz4-1.1.ebuild > > ># Copyright 1999-2018 Gentoo Foundation > ># Distributed under the terms of the GNU General Public License v2 > > > >EAPI=6 > > > >DESCRIPTION="Decompress Mozilla Firefox bookmarks backup files" > >HOMEPAGE="https://github.com/avih/dejsonlz4/" > >SRC_URI="https://github.com/avih/dejsonlz4/archive/v1.1.zip" > > If every ebuild did this, DISTDIR would be full of things named > "v{version}.zip". We instead use redirects that looks like this: > > https://github.com/avih/dejsonlz4/archive/v1.1.zip -> ${P}.zip > > where ${P} stands for ${PN}-${PV} and > where ${PN} is the package name and > where ${PV} is the package version. > > > > >LICENSE="BSD-2" > >SLOT="0" > >KEYWORDS="~amd64 ~x86" > > > >src_install() { > > This is the build phase where you install things. > > > gcc -Wall -o dejsonlz4 src/dejsonlz4.c src/lz4.c > > The build phase that compiles things is src_compile() not src_install(). > > Your ebuild should respect the compiler executable set in the CC variable > instead of hard-coding "gcc". > Your ebuild should use the compiler flags set in the CFLAGS variable. > > > dobin dejsonlz4 > >} Sorry. Fixed version: https://bugs.gentoo.org/attachment.cgi?id=519126 you def. should update that eapi |