Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 646850

Summary: dev-util/gtk-doc fails to generate pdfs, thus whole builds may fail
Product: Gentoo Linux Reporter: David Haller <gentoo>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: zmedico
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: fix exit status, pass on verbosity to dblatex

Description David Haller 2018-02-07 01:22:19 UTC
Created attachment 518300 [details, diff]
fix exit status, pass on verbosity to dblatex

While building evince wanting to generate pdfs via gtk-doc, I noticed that the build
failed, though everything looked ok. I tracked it down to a missing $ in front of a 1
in gtkdoc-mkpdf.in ... *g*

Patch attached, that additionally makes gtkdoc-mkpdf pass on the verbosity flag
to dblatex.
Comment 1 Larry the Git Cow gentoo-dev 2018-08-26 06:56:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1f0c43e476dfad520cc03a117b55f77bb53fd45

commit b1f0c43e476dfad520cc03a117b55f77bb53fd45
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-08-26 06:35:20 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-08-26 06:55:59 +0000

    dev-util/gtk-doc: mkpdf: fix exitcode (bug 646850)
    
    Fix gtk-doc exitcode. The problem can be demonstrated by building
    gtk-doc with dblatex installed, and then building evince with
    EXTRA_ECONF="--enable-gtk-doc --enable-gtk-doc-pdf".
    
    Bug: https://bugs.gentoo.org/646850
    See: https://github.com/GNOME/gtk-doc/commit/1baf9a63bdf3283832be06bce151835922909436
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 dev-util/gtk-doc/gtk-doc-1.25-r1.ebuild | 4 ++++
 1 file changed, 4 insertions(+)
Comment 2 Zac Medico gentoo-dev 2018-08-26 06:58:02 UTC
(In reply to David Haller from comment #0)
> Patch attached, that additionally makes gtkdoc-mkpdf pass on the verbosity
> flag to dblatex.

The verbosity enhancement should be sent upstream, since they're not doing that in the current python implementation:

https://github.com/GNOME/gtk-doc/blob/master/gtkdoc/mkpdf.py
Comment 3 RĂ©mi Cardona (RETIRED) gentoo-dev 2020-01-26 09:11:01 UTC
Looks like it's fixed in 1.32, closing.

https://gitlab.gnome.org/GNOME/gtk-doc/blob/GTK_DOC_1_32/gtkdoc/mkpdf.py#L128