Summary: | games-action/openclonk-8.1: version bump, IUSE=doc needs py3 port or be dropped | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Julius <gentoobug> |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra, jstein, pacho, treecleaner |
Priority: | Normal | Keywords: | PMASKED |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://blog.openclonk.org/2018/03/openclonk-8-1-released/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 694800, 574082 | ||
Deadline: | 2020-09-21 | ||
Attachments: |
Updated ebuild, has changes from #588236, needs to have git removed
fixed metadata.xml fixed ebuild |
Description
Julius
2018-02-06 10:47:37 UTC
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman * eutils is not needed here since EAPI=6 * KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) "# Copyright 1999-2018 Gentoo Foundation" * fdo-mime is obsolete, please use xdg-utils * It would be better to attach the single files instead of a compressed file. Created attachment 518356 [details]
fixed metadata.xml
Created attachment 518358 [details]
fixed ebuild
I made the warnings go away and did what you said, but I'm still not sure that makes this a good ebuild.
Hm, two questions: 1. Is there a nice way to check whether the listed dependencies are really sufficient/necessary? At least gtk3 seems to be unnecessary at this point (It's only used to build the mape tool, which the ebuild doesn't install.) 2. There is extra music available at http://www.openclonk.org/download/Music.ocg, but the license is… odd at best. "The game Open Clonk ( http://www.openclonk.org/ ) may use and distribute the soundtrack, as long as credit is given. This explicitly includes packaged distributions of the game. In-game videos of Open Clonk and game modifications and extensions based on the Open Clonk file-types (.ocd, .ocs and .ocf) don't require credits." Any way to have this as an extra download, or something? Small change: It's 8.1 now… Please use tarball from https://www.openclonk.org//builds/release/8.1/openclonk-8.1-src.tar.bz2 Instead of using your local git tree Thanks I made an overlay for this a while ago… https://github.com/jcaesar/openclonk-overlay Not sure what to do with this issue now. Porting to python 3 seems to be non-trivial. I would suggest to remove the doc flag (and have done so on my overlay). (The doc flag currently builds the documentation necessary for developing add-ons to the game. It is certainly not of high importance…) ping. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=092f0475e01cc01175c7b51348fcc32fe49c1f79 commit 092f0475e01cc01175c7b51348fcc32fe49c1f79 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2020-08-22 08:03:39 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2020-08-22 08:04:18 +0000 package.mask: Last rite games-action/openclonk Bug: https://bugs.gentoo.org/646748 Signed-off-by: Michał Górny <mgorny@gentoo.org> profiles/package.mask | 6 ++++++ 1 file changed, 6 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d36ae2a4b127f5510f6786642229e514e52028c8 commit d36ae2a4b127f5510f6786642229e514e52028c8 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2020-09-21 05:56:09 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2020-09-21 05:56:44 +0000 games-action/openclonk: Remove last-rited pkg Closes: https://bugs.gentoo.org/646748 Signed-off-by: Michał Górny <mgorny@gentoo.org> games-action/openclonk/Manifest | 1 - .../openclonk/files/openclonk-7.0-paths.patch | 68 ------------ .../openclonk/files/openclonk-7.0-postinst.patch | 14 --- .../openclonk/files/openclonk-wrapper-script.sh | 9 -- games-action/openclonk/metadata.xml | 23 ----- games-action/openclonk/openclonk-7.0.ebuild | 114 --------------------- profiles/package.mask | 6 -- 7 files changed, 235 deletions(-) |