Bug 646206 – mail-client/thunderbird should not inherit/use makeedit.eclass

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Felix Janda 2018-01-31 13:08:27 UTC]

mail-client/thunderbird is the only package using makeedit.eclass. The
inherit has only indirectly any effect at all, since MAKEEDIT_FLAGS is
used in mozcoreconf-v*.eclass. From what I can see, this suppresses all
warnings when building thunderbird. I'm not sure this is really
desirable.

Please consider removing the inherit from mail-client/thunderbird and
the relevant line from mozcoreconf-v*.eclass.

[Comment 1 Jonas Stein 2018-01-31 13:18:23 UTC]

Makeedit [1] is indeed used only by thunderbird [2].

[1] https://devmanual.gentoo.org/eclass-reference/makeedit.eclass/index.html
[2] https://qa-reports.gentoo.org/output/eclass-usage/makeedit.txt

[Comment 2 Larry the Git Cow 2018-01-31 15:24:00 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52094faae767bdc3c0d9a6fa33bd70b663b3906e

commit 52094faae767bdc3c0d9a6fa33bd70b663b3906e
Author:     Ian Stakenvicius <[e-mail]>
AuthorDate: 2018-01-31 14:55:52 +0000
Commit:     Ian Stakenvicius <[e-mail]>
CommitDate: 2018-01-31 15:23:53 +0000

    mozcoreconf-*.eclass:  remove " append-flags $MAKEEDIT_FLAGS "
    
    We do not inherit makeedit in this eclass and so the only ebuilds that had
    anything to append were thunderbird ones.  Removing for simplicity rather
    than inheriting makeedit.eclass to make the append work.
    
    Bug: http://bugs.gentoo.org/646206

 eclass/mozcoreconf-v4.eclass | 3 ---
 eclass/mozcoreconf-v5.eclass | 3 ---
 2 files changed, 6 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d516da64b5cab2e583c752798b95b9c2dbdcd93

commit 8d516da64b5cab2e583c752798b95b9c2dbdcd93
Author:     Ian Stakenvicius <[e-mail]>
AuthorDate: 2018-01-31 14:51:25 +0000
Commit:     Ian Stakenvicius <[e-mail]>
CommitDate: 2018-01-31 15:23:47 +0000

    mail-client/thunderbird: remove makeedit.eclass from inherit
    
    Bug: http://bugs.gentoo.org/646206
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 mail-client/thunderbird/thunderbird-45.8.0.ebuild | 4 ++--
 mail-client/thunderbird/thunderbird-52.5.0.ebuild | 4 ++--
 mail-client/thunderbird/thunderbird-52.5.2.ebuild | 2 +-
 mail-client/thunderbird/thunderbird-52.6.0.ebuild | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)}

[Comment 3 Ian Stakenvicius (RETIRED) 2018-01-31 15:36:14 UTC]

I see no reason to try and keep this, especially since its been quite some time since it's done nothing on firefox.  Removing as per commits above.