Bug 646106

Summary:	net-wireless/broadcom-sta-6.30.223.271-r4 with kernel 4.15.0 - .../work/src/wl/sys/wl_linux.c:2358:2: error: implicit declaration of function ‘init_timer’; did you mean ‘init_timers’? [-Werror=implicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Aleksandr K. <aleksandr>
Component:	Current packages	Assignee:	M. B. <tomboy64>
Status:	RESOLVED FIXED
Severity:	normal	CC:	eva, joost.ruis, matoro_bugzilla_gentoo, proxy-maint, sarnex
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/7449
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build_emerge.zip new_timer_api.patch

Description Aleksandr K. 2018-01-30 08:33:48 UTC

Created attachment 517104 [details]
build_emerge.zip

Can't build broadcom-sta on kernel 4.15.0

...

/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.c: In function ‘wl_init_timer’:
/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.c:2358:2: error: implicit declaration of function ‘init_timer’; did you mean ‘init_timers’? [-Werror=implicit-function-declaration]
  init_timer(&t->timer);
  ^~~~~~~~~~
  init_timers
/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.c:2359:10: error: ‘struct timer_list’ has no member named ‘data’
  t->timer.data = (ulong) t;
          ^
/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.c:2360:20: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
  t->timer.function = wl_timer;
                    ^
At top level:
/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.c:828:1: warning: ‘wl_resume’ defined but not used [-Wunused-function]
 wl_resume(struct device *dev)
 ^~~~~~~~~
/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.c:796:1: warning: ‘wl_suspend’ defined but not used [-Wunused-function]
 wl_suspend(struct device *dev)
 ^~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:317: /var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work/src/wl/sys/wl_linux.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1685: wl.ko] Error 2
make: Leaving directory '/usr/src/linux-4.15.0-gentoo'
 * ERROR: net-wireless/broadcom-sta-6.30.223.271-r4::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=net-wireless/broadcom-sta-6.30.223.271-r4::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-wireless/broadcom-sta-6.30.223.271-r4::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/temp/environment'.
 * Working directory: '/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work'
 * S: '/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/work'

>>> Failed to emerge net-wireless/broadcom-sta-6.30.223.271-r4, Log file:

>>>  '/var/tmp/portage/net-wireless/broadcom-sta-6.30.223.271-r4/temp/build.log'

...

Comment 1 Aleksandr K. 2018-02-02 14:52:49 UTC

Still no info and unconfirmed??

Comment 2 Nick Sarnie gentoo-dev

2018-02-03 19:28:57 UTC

Created attachment 517670 [details, diff]
new_timer_api.patch

The kernel changed the timer API in 4.15. The attached patch should work.


Sarnex

Comment 3 Marco Kull 2018-02-04 12:37:09 UTC

Thanks Sarnex, the patch you provided fixed the problem.

Comment 4 Aleksandr K. 2018-02-04 12:55:59 UTC

Can confirm, new_time_api.patch resolve issue with new kernel.
Thank you, Nick Sarnie!

Comment 5 Dmitry Grigoriev 2018-02-12 02:44:22 UTC

Confirm both problem and solution, thanks Nick!

Comment 6 Pacho Ramos gentoo-dev

2018-03-13 16:30:41 UTC

Nick mailed me showing interest on fixing and maintaining this. Probably the way to do (until you become a developer) would be to maintain it via proxy-maint and send a PR fixing the existing bugs
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

Comment 7 Larry the Git Cow gentoo-dev

2018-03-25 22:07:53 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=512c492ad7da750b2d9e1c794b2dee8c774eb3aa

commit 512c492ad7da750b2d9e1c794b2dee8c774eb3aa
Author:     Nick Sarnie <commendsarnex@gmail.com>
AuthorDate: 2018-03-13 19:17:30 +0000
Commit:     Gilles Dartiguelongue <eva@gentoo.org>
CommitDate: 2018-03-25 22:07:42 +0000

    net-wireless/broadcom-sta: Fix build on 4.15
    
    Bug: https://bugs.gentoo.org/646106
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    Closes: https://github.com/gentoo/gentoo/pull/7449

 .../broadcom-sta-6.30.223.271-r4.ebuild            |  5 +-
 .../broadcom-sta-6.30.223.271-r4-linux-4.15.patch  | 63 ++++++++++++++++++++++
 2 files changed, 66 insertions(+), 2 deletions(-)}