Bug 646096 – app-laptop/tp_smapi-0.42-r1 does not compile against linux 4.15.0

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jeremy Stent 2018-01-30 03:31:32 UTC]

app-laptop/tp_smapi does not compile against the latest kernel.  There is a patch against it at https://github.com/evgeni/tp_smapi/issues/31 .  Patch link is http://www.sec.t-labs.tu-berlin.de/~jan/0001-Adapt-HDAPS-driver-to-use-the-new-timer_setup-interf.patch .

Reproducible: Always

Steps to Reproduce:
1.  Use a 4.15.0 or greater linux kernel
2.  Attempt to emerge app-laptop/tp_smapi

Actual Results:  
make[2]: Entering directory '/usr/src/linux-4.15.0-gentoo'
  CC [M]  /misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/thinkpad_ec.o
  CC [M]  /misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/tp_smapi.o
  CC [M]  /misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.o
/misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.c: In function ‘hdaps_init’:
/misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.c:781:2: error: implicit declaration of function ‘init_timer’; did you mean ‘init_timers’? [-Werror=implicit-function-declaration]
  init_timer(&hdaps_timer);
  ^~~~~~~~~~
  init_timers
/misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.c:782:23: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
  hdaps_timer.function = hdaps_mousedev_poll;
                       ^
cc1: some warnings being treated as errors
make[3]: *** [/usr/src/linux-4.15.0-gentoo/scripts/Makefile.build:322: /misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.o] Error 1
make[2]: *** [/usr/src/linux-4.15.0-gentoo/Makefile:1508: _module_/misc/portage/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42] Error 2


Expected Results:  
Successful merge.

[Comment 1 Larry the Git Cow 2018-01-30 04:01:55 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a39ab58e766da4ad5021445cccf99b372b621a98

commit a39ab58e766da4ad5021445cccf99b372b621a98
Author:     Michael Orlitzky <[e-mail]>
AuthorDate: 2018-01-30 03:56:53 +0000
Commit:     Michael Orlitzky <[e-mail]>
CommitDate: 2018-01-30 03:59:31 +0000

    app-laptop/tp_smapi: new revision to fix the build with >= linux-4.15.
    
    Closes: https://bugs.gentoo.org/646096
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../files/linux-4.15-timer_setup-fix.patch         | 43 ++++++++++++
 app-laptop/tp_smapi/tp_smapi-0.42-r2.ebuild        | 76 ++++++++++++++++++++++
 2 files changed, 119 insertions(+)

[Comment 2 Michael Orlitzky 2018-01-30 04:03:16 UTC]

I can't test it at the moment because my kernel situation is all screwed up, but I just added tp_smapi-0.42-r2 to the tree with the patch. Can you please make sure it works?

[Comment 3 Jeremy Stent 2018-01-30 14:25:07 UTC]

This seems to work fine for kernel 4.15 and for an earlier kernel.  Thank you for your assistance.