| Summary: | <net-firewall/pglinux-2.3.1_p20171006 optionally depends on deprecated Qt4 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andreas Sturmlechner <asturm> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 631788 | ||
| Attachments: |
pglinux-2.3.1-r1.ebuild
pglinux-qt5.patch pglinux-2.3.1-r1.ebuild pglinux-2.3.1-r1.ebuild pglinux-qt5.patch |
||
|
Description
Andreas Sturmlechner
2018-01-23 00:58:22 UTC
Feel free to go ahead with "maintainer-needed" packages ;) I can always drop the Qt4 option, but I rather have someone using this software look into a bump if possible. It's been a while when the last version has been released by the upstream, but application is still developed. Development of this app would not be a synonym of fast, but I have found the following in the code which shows in the master they changed to QT5 2 years ago. https://sourceforge.net/p/peerguardian/code/ci/700e4a74d3b604c43ab7b98c5d1a254f4b03a93d/ https://sourceforge.net/p/peerguardian/code/ci/84f005e104195f374a1caf31e58d1c9332c5e003/ https://sourceforge.net/p/peerguardian/code/ci/83e6cd504fd063b275e25cfa6782ae822bf192aa/ Maybe they can be backported as patches o resolve this bug? Do you think you are up to the task and maybe want to give it a try? :) Created attachment 517060 [details]
pglinux-2.3.1-r1.ebuild
I do not have on my server even xserver much less QT than I am unable to test it, but in theory it should work
Created attachment 517062 [details, diff]
pglinux-qt5.patch
and patch itself
Created attachment 517096 [details]
pglinux-2.3.1-r1.ebuild
This ebuild unlike the previous which deals only with QT5 also adds few missing use flags.
Created attachment 517106 [details]
pglinux-2.3.1-r1.ebuild
Forgot that running autogen is required... Now it must work ;)
Created attachment 517108 [details, diff]
pglinux-qt5.patch
removed from patch creation of unneeded debian file
Thanks for your contribution! I'm afraid there are more commits required:
In file included from src/settings.h:30:0,
from src/blocklist.h:24,
from src/list_item.h:26,
from src/list_item.cpp:21:
./ui/ui_settings.h:13:10: fatal error: QtGui/QAction: No such file or directory
#include <QtGui/QAction>
^~~~~~~~~~~~~~~
compilation terminated.
Maybe a snapshot would be less tedious than picking all the necessary qt5 commits?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42666d3e96349be58cfd34a0b5fa8e283ce8716b commit 42666d3e96349be58cfd34a0b5fa8e283ce8716b Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-04-08 20:03:01 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-04-08 20:10:50 +0000 net-firewall/pglinux: Add 2.3.1_p20171006 Qt5-based snapshot Dropped keywords because completely runtime-untested. Bug: https://bugs.gentoo.org/645432 Package-Manager: Portage-2.3.28, Repoman-2.3.9 net-firewall/pglinux/Manifest | 1 + .../pglinux/pglinux-2.3.1_p20171006.ebuild | 107 +++++++++++++++++++++ 2 files changed, 108 insertions(+)} I've added above snapshot without keywords. Please test! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1330c6e86cb313ee831761be05bef3112a44d900 commit 1330c6e86cb313ee831761be05bef3112a44d900 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-04-13 19:46:24 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-04-13 19:59:49 +0000 net-firewall/pglinux: Drop old Qt4-based Closes: https://bugs.gentoo.org/645432 Package-Manager: Portage-2.3.28, Repoman-2.3.9 net-firewall/pglinux/Manifest | 1 - net-firewall/pglinux/pglinux-2.3.1.ebuild | 99 ------------------------------- 2 files changed, 100 deletions(-) |