|Summary:||<net-firewall/pglinux-2.3.1_p20171006 optionally depends on deprecated Qt4|
|Product:||Gentoo Linux||Reporter:||Andreas Sturmlechner <asturm>|
|Component:||Current packages||Assignee:||No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
Description Andreas Sturmlechner 2018-01-23 00:58:22 UTC
Qt4 is dead and going away. While upstream git master is already Qt5-based, development is slow. If its current state is not stable enough for a snapshot, maybe the Qt4 option should be dropped.
Comment 1 Pacho Ramos 2018-01-23 10:06:18 UTC
Feel free to go ahead with "maintainer-needed" packages ;)
Comment 2 Andreas Sturmlechner 2018-01-23 18:01:53 UTC
I can always drop the Qt4 option, but I rather have someone using this software look into a bump if possible.
Comment 3 Wojciech Myrda 2018-01-24 12:29:52 UTC
It's been a while when the last version has been released by the upstream, but application is still developed. Development of this app would not be a synonym of fast, but I have found the following in the code which shows in the master they changed to QT5 2 years ago. https://sourceforge.net/p/peerguardian/code/ci/700e4a74d3b604c43ab7b98c5d1a254f4b03a93d/ https://sourceforge.net/p/peerguardian/code/ci/84f005e104195f374a1caf31e58d1c9332c5e003/ https://sourceforge.net/p/peerguardian/code/ci/83e6cd504fd063b275e25cfa6782ae822bf192aa/ Maybe they can be backported as patches o resolve this bug?
Comment 4 Andreas Sturmlechner 2018-01-25 23:24:57 UTC
Do you think you are up to the task and maybe want to give it a try? :)
Comment 5 Wojciech Myrda 2018-01-29 14:55:24 UTC
Created attachment 517060 [details] pglinux-2.3.1-r1.ebuild I do not have on my server even xserver much less QT than I am unable to test it, but in theory it should work
Comment 6 Wojciech Myrda 2018-01-29 14:56:18 UTC
Created attachment 517062 [details, diff] pglinux-qt5.patch and patch itself
Comment 7 Wojciech Myrda 2018-01-30 07:57:33 UTC
Created attachment 517096 [details] pglinux-2.3.1-r1.ebuild This ebuild unlike the previous which deals only with QT5 also adds few missing use flags.
Comment 8 Wojciech Myrda 2018-01-30 08:58:59 UTC
Created attachment 517106 [details] pglinux-2.3.1-r1.ebuild Forgot that running autogen is required... Now it must work ;)
Comment 9 Wojciech Myrda 2018-01-30 09:01:02 UTC
Created attachment 517108 [details, diff] pglinux-qt5.patch removed from patch creation of unneeded debian file
Comment 10 Andreas Sturmlechner 2018-01-31 00:39:36 UTC
Thanks for your contribution! I'm afraid there are more commits required: In file included from src/settings.h:30:0, from src/blocklist.h:24, from src/list_item.h:26, from src/list_item.cpp:21: ./ui/ui_settings.h:13:10: fatal error: QtGui/QAction: No such file or directory #include <QtGui/QAction> ^~~~~~~~~~~~~~~ compilation terminated. Maybe a snapshot would be less tedious than picking all the necessary qt5 commits?
Comment 11 Larry the Git Cow 2018-04-08 20:11:06 UTC
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42666d3e96349be58cfd34a0b5fa8e283ce8716b commit 42666d3e96349be58cfd34a0b5fa8e283ce8716b Author: Andreas Sturmlechner <email@example.com> AuthorDate: 2018-04-08 20:03:01 +0000 Commit: Andreas Sturmlechner <firstname.lastname@example.org> CommitDate: 2018-04-08 20:10:50 +0000 net-firewall/pglinux: Add 2.3.1_p20171006 Qt5-based snapshot Dropped keywords because completely runtime-untested. Bug: https://bugs.gentoo.org/645432 Package-Manager: Portage-2.3.28, Repoman-2.3.9 net-firewall/pglinux/Manifest | 1 + .../pglinux/pglinux-2.3.1_p20171006.ebuild | 107 +++++++++++++++++++++ 2 files changed, 108 insertions(+)}
Comment 12 Andreas Sturmlechner 2018-04-08 20:13:17 UTC
I've added above snapshot without keywords. Please test!
Comment 13 Larry the Git Cow 2018-04-13 20:00:16 UTC
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1330c6e86cb313ee831761be05bef3112a44d900 commit 1330c6e86cb313ee831761be05bef3112a44d900 Author: Andreas Sturmlechner <email@example.com> AuthorDate: 2018-04-13 19:46:24 +0000 Commit: Andreas Sturmlechner <firstname.lastname@example.org> CommitDate: 2018-04-13 19:59:49 +0000 net-firewall/pglinux: Drop old Qt4-based Closes: https://bugs.gentoo.org/645432 Package-Manager: Portage-2.3.28, Repoman-2.3.9 net-firewall/pglinux/Manifest | 1 - net-firewall/pglinux/pglinux-2.3.1.ebuild | 99 ------------------------------- 2 files changed, 100 deletions(-)