Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 645232

Summary: dev-lang/orc: Suboptimal orc-test handling with meson build
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: GStreamer package maintainers <gstreamer>
Status: CONFIRMED ---    
Severity: normal CC: jarausch, mattst88, nelo, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
logs.tbz2
media-libs:gst-plugins-base-0.10.36-r2:20180121-112214.log
temp.tbz2

Description Toralf Förster gentoo-dev 2018-01-21 11:26:48 UTC
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/media-libs/gst-plugins-base-0.10.36-r2/work/gst-plugins-base-0.10.36/gst/audioresample -I../.. -I/var/tmp/portage/media-libs/gst-plugins-base-0.10.36-r2/work/gst-plugins-base-0.10.36/gst-libs -I../../gst-libs -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Waggregate-return -Wno-multichar -Wnested-externs -I/usr/include/orc-0.4 -O2 -pipe -march=native -c /var/tmp/portage/media-libs/gst-plugins-base-0.10.36-r2/work/gst-plugins-base-0.10.36/gst/audioresample/gstaudioresample.c  -fPIC -DPIC -o .libs/libgstaudioresample_la-gstaudioresample.o
/var/tmp/portage/media-libs/gst-plugins-base-0.10.36-r2/work/gst-plugins-base-0.10.36/gst/audioresample/gstaudioresample.c:55:10: fatal error: orc-test/orctest.h: No such file or directory
 #include <orc-test/orctest.h>
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-desktop_libressl_20180117-212758

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.2.0 *

Available Python interpreters, in order of preference:
  [1]   python3.5
  [2]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby22 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.6.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

emerge -qpv media-libs/gst-plugins-base
[ebuild   R   ] media-libs/gst-plugins-base-1.12.3  USE="X alsa introspection nls ogg orc pango vorbis -ivorbis -theora" ABI_X86="(64) -32 (-x32)"
Comment 1 Toralf Förster gentoo-dev 2018-01-21 11:26:51 UTC
Created attachment 515618 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2018-01-21 11:26:54 UTC
Created attachment 515620 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2018-01-21 11:26:56 UTC
Created attachment 515622 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2018-01-21 11:26:59 UTC
Created attachment 515624 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2018-01-21 11:27:02 UTC
Created attachment 515626 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2018-01-21 11:27:05 UTC
Created attachment 515628 [details]
media-libs:gst-plugins-base-0.10.36-r2:20180121-112214.log
Comment 7 Toralf Förster gentoo-dev 2018-01-21 11:27:08 UTC
Created attachment 515630 [details]
temp.tbz2
Comment 8 Mart Raudsepp gentoo-dev 2018-01-21 11:31:23 UTC
sigh, ancient gst-plugins-base:0.10 seems to include the header now installed only with orc[test] just for fun or something.
Comment 9 Larry the Git Cow gentoo-dev 2018-01-21 11:59:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b10e3ba19c61c57cef8c59218732f7bfb1b13f91

commit b10e3ba19c61c57cef8c59218732f7bfb1b13f91
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-01-21 11:41:49 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-01-21 11:56:03 +0000

    dev-lang/orc: install test headers always, used by some things
    
    Bug: https://bugs.gentoo.org/645232
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 dev-lang/orc/orc-0.4.28-r1.ebuild | 73 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)}
Comment 10 Mart Raudsepp gentoo-dev 2018-01-21 12:03:03 UTC
Moved back to always building and installing the test stuff for orc; not sure anymore we should be passing it at all until it controls header and library installs too (decided to try it on bump despite seeing it, not thinking some ancient -base will be including it). Leaving open to try again later or investigate if we can disable testsuite building somehow still without FEATURES=test
Comment 11 Mart Raudsepp gentoo-dev 2018-01-21 17:41:33 UTC
*** Bug 645264 has been marked as a duplicate of this bug. ***
Comment 12 Mart Raudsepp gentoo-dev 2019-06-22 08:53:50 UTC
With 0.10 gone, maybe we can revisit the orc build to not ship that part anymore
Comment 13 Larry the Git Cow gentoo-dev 2019-11-23 21:41:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3633014ee6b3f8d556d44cc59b5ec6ebf516504

commit e3633014ee6b3f8d556d44cc59b5ec6ebf516504
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2019-11-21 19:39:26 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-11-23 21:41:20 +0000

    dev-lang/orc: Version bump to 0.4.31
    
    - Convert to Meson (autotools build system was removed)
    - EAPI=7
    - Drop Darwin hack
    - Drop IUSE=pax_kernel
    
    Bug: https://bugs.gentoo.org/691804
    Closes: https://bugs.gentoo.org/554600
    Closes: https://bugs.gentoo.org/645232
    Closes: https://bugs.gentoo.org/698272
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 dev-lang/orc/Manifest          |  1 +
 dev-lang/orc/orc-0.4.31.ebuild | 43 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
Comment 14 Mart Raudsepp gentoo-dev 2020-01-27 18:24:02 UTC
I don't see anything fixed here, in terms of why this bug had to be filed in the first place - orc-test is still unconditionally installed on the system, while the intention was to perhaps not do that. Now it was just relying on implicit enablement of this, while it actually errors if it somehow gets turned off and tests are enabled.
Comment 15 Mart Raudsepp gentoo-dev 2020-01-27 18:26:28 UTC
Additionally now 0.4.31 is always installing a liborc-test-0.4.a, despite USE=-static-libs
Comment 16 Larry the Git Cow gentoo-dev 2023-05-30 23:54:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=49f74715b1cda34f8cbf3698f6b1b1394e19a149

commit 49f74715b1cda34f8cbf3698f6b1b1394e19a149
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-30 23:53:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-30 23:53:51 +0000

    dev-lang/orc: add 0.4.34
    
    No static lib is installed now (fixed upstream) for orc-test. But I assume
    (not checked, at least not yet) that gst still needs the orc-test header.
    
    Bug: https://bugs.gentoo.org/645232
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-lang/orc/Manifest          |  1 +
 dev-lang/orc/orc-0.4.34.ebuild | 39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+)
Comment 17 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-30 23:55:27 UTC
In gstreamer master, I still see:
```
orc_test_dep = dependency('', required : false)
if have_orcc
  # FIXME: there should really just be a separate orc-test-0.4.pc file for this
  if orc_dep.type_name() == 'pkgconfig'
    orc_test_dep = cc.find_library('orc-test-0.4', required : false)
  else
    orc_test_dep = dependency('', fallback: ['orc', 'orc_test_dep'], required: false)
  endif
endif
```

in good/bad, but I don't see any include for the header. But seems like orc-test itself is used still?