Summary: | [prefix/cygwin] cmake.eclass is broken for cygwin prefix | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Sven Eden <sven.eden> |
Component: | Prefix Support | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED WONTFIX | ||
Severity: | major | CC: | prefix |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | fix_cmake-utils.eclass_for_cygwin.patch |
Description
Sven Eden
2018-01-18 09:47:49 UTC
Created attachment 515224 [details, diff]
fix_cmake-utils.eclass_for_cygwin.patch
This patch let's CYGWIN prefixes to be handled like APPLE ones. Further I am playing safe and make sure that WIN32 is definitely *not* set.
The letter should be superfluous, but it doesn't hurt either.
I am pretty sure discovering this bug is the best thing that happened to me today so far. Thanks! Why has this been assigned to @kde? Should we reassign to @prefix? I think because kde is the owner of the eclass Please rebase your patch against cmake.eclass and send it to gentoo-dev mailing list for review. Ping, is this still necessary? Please note that cmake-utils.eclass is deprecated and any fixes only go into cmake.eclass. Sorry folks, I have totally forgotten about this bug. With Gentoo running perfectly fine in WSL, I haven't used Cygwin with Gentoo Prefix for over a year now. I don't even know if any patch is still needed. More than this, I found Cygwin to be a dead end on many aspects. Their forking issues continue, and disk access is hilariously slow. Their own software works well, and I no longer see any advantage in plugging a Gentoo Prefix into that. Well, other than to prove that is possible. So from my point of view, this bug could as well be closed. Again, I fully apologize to have forgotten about this issue! (In reply to Sven Eden from comment #7) > Sorry folks, I have totally forgotten about this bug. > > With Gentoo running perfectly fine in WSL, I haven't used Cygwin with Gentoo > Prefix for over a year now. > > I don't even know if any patch is still needed. > > More than this, I found Cygwin to be a dead end on many aspects. Their > forking issues continue, and disk access is hilariously slow. Their own > software works well, and I no longer see any advantage in plugging a Gentoo > Prefix into that. Well, other than to prove that is possible. The question is if native Windows binaries like MSVC toolchain (cl.exe&co) can be run from within WSL these days. As soon as that one does reliably work, we indeed have no real need for Cygwin any more as well. > So from my point of view, this bug could as well be closed. As we've phased out Subversion here, we don't have need for CMake on Cygwin any more too. |