Bug 644896

Summary:	mail-client/roundcube: bundled pear libs
Product:	Gentoo Linux	Reporter:	Michael Orlitzky <mjo>
Component:	Current packages	Assignee:	Aaron W. Swenson <titanofold>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gentoo_bugs_peep, hydrapolic, web-apps
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=650910
Whiteboard:
Package list:		Runtime testing required:	---

Description Michael Orlitzky gentoo-dev

2018-01-18 00:41:34 UTC

These days, Roundcube bundles ALL of its libraries, even though it is capable of using the system PEAR libraries if they exist. For example, the vendor/pear directory contains...

  pear:
  total 48K
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 auth_sasl
  drwxr-x---+ 4 root root 4.0K 2018-01-17 19:11 console_commandline
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 console_getopt
  drwxr-x---+ 5 root root 4.0K 2018-01-17 19:11 crypt_gpg
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 mail_mime
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 net_idna2
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 net_ldap2
  drwxr-x---+ 2 root root 4.0K 2018-01-17 19:11 net_sieve
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 net_smtp
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 net_socket
  drwxr-x---+ 3 root root 4.0K 2018-01-14 08:00 pear-core-minimal
  drwxr-x---+ 3 root root 4.0K 2018-01-17 19:11 pear_exception

Most of these are still pulled into RDEPEND in the ebuild:

  RDEPEND="...
	>=dev-php/PEAR-Auth_SASL-1.1.0
	>=dev-php/PEAR-Mail_Mime-1.10.0
	...

Fortunately, I think all you have to do is delete the copies under vendor/pear to make Roundcube use the system ones. I've just installed roundcube-1.3.4 (by hand, not with the ebuild) on our mail server, and that trick seems to have worked.

Comment 1 Michael Orlitzky gentoo-dev

2018-01-18 00:48:13 UTC

For the record, this only works with the bundled PEAR stuff as far as I know. This is what I've got in our "upgrading" document:

	rm -r public/vendor/pear/auth_sasl
	rm -r public/vendor/pear/crypt_gpg
	rm -r public/vendor/pear/mail_mime
	rm -r public/vendor/pear/net_idna2
	rm -r public/vendor/pear/net_sieve
	rm -r public/vendor/pear/net_smtp
	rm -r public/vendor/pear/net_socket

I didn't push my luck, and have not tried replacing vendor/pear/pear_exception with dev-php/PEAR-Exception.

Comment 2 Aaron W. Swenson gentoo-dev

2018-01-18 13:14:36 UTC

Yeah, I was going to ask what happens if you just remove the vendor/pear directory altogether.

Comment 3 Michael Orlitzky gentoo-dev

2018-01-19 02:27:43 UTC

> what happens if you just remove the vendor/pear directory altogether

*fingers crossed* it seems OK with the latest PEAR-PEAR and PEAR-Exception

Comment 4 Larry the Git Cow gentoo-dev

2018-01-23 11:58:44 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f36840f6b7a3e5f398ff07be23c6d110c4efe8c4

commit f36840f6b7a3e5f398ff07be23c6d110c4efe8c4
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2018-01-23 11:58:30 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2018-01-23 11:58:30 +0000

    mail-client/roundcube: Bump to 1.3.4
    
    Now removes bundled PEAR libs/modules/whatever they’re called, and
    depends on the related ebuilds.
    
    Closes: https://bugs.gentoo.org/644896
    Closes: https://bugs.gentoo.org/645374
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 mail-client/roundcube/Manifest               |  1 +
 mail-client/roundcube/roundcube-1.3.4.ebuild | 99 ++++++++++++++++++++++++++++
 2 files changed, 100 insertions(+)