Bug 644182 – sys-libs/ncurses needs is-tc-static fix

• Product: Gentoo/Alt
• Status: RESOLVED OBSOLETE

[Description Alan Hourihane 2018-01-11 08:44:13 UTC]

The multicode here....

multilib_src_install() {
local target lib
	for target in "${NCURSES_TARGETS[@]}" ; do
		cd "${BUILD_DIR}/${target}/lib" || die
		for lib in *$(get_libname 5.9) ; do
			newlib.so "${lib}" "${lib%%.9}"
		done
	done
}

should be...

multilib_src_install() {
        if ! tc-is-static-only ; then
        	local target lib
	        for target in "${NCURSES_TARGETS[@]}" ; do
		        cd "${BUILD_DIR}/${target}/lib" || die
        		for lib in *$(get_libname 5.9) ; do
	        		newlib.so "${lib}" "${lib%%.9}"
		        done
        	done
        fi
}

[Comment 1 Alan Hourihane 2018-01-11 08:45:48 UTC]

Actually, it's a little more complex. Will update.

[Comment 2 Alan Hourihane 2018-01-11 16:02:11 UTC]

Changed to this...

multilib_src_install() {
	local target lib
	for target in "${NCURSES_TARGETS[@]}" ; do
		if tc-is-static-only ; then
        	        emake -C "${BUILD_DIR}/${target}" DESTDIR="${D}" install
		else
			cd "${BUILD_DIR}/${target}/lib" || die
			for lib in *$(get_libname 5.9) ; do
				newlib.so "${lib}" "${lib%%.9}"
			done
		fi
	done
}

[Comment 3 Fabian Groffen 2018-01-11 17:13:44 UTC]

I don't think that will work, as on Darwin get_libname 5.9 would return .5.9.dylib (iso .so.5.9).

[Comment 4 Alan Hourihane 2018-01-11 17:22:35 UTC]

I'm not changing anything related to get_libname, I'm only adding the code...

    if tc-is-static-only ; then
        emake -C "${BUILD_DIR}/${target}" DESTDIR="${D}" install
    else
        ....
    if

NOTE: this is only for ncurses 5.9, I think ncurses 6.0 has changed, which I'm building now.

[Comment 5 SpanKY 2018-06-25 21:44:08 UTC]

please write a proper patch & send it via a GH PR for us to review/merge

[Comment 6 Fabian Groffen 2021-01-06 11:58:05 UTC]

m68k-mint had to be dropped