Bug 643944

Summary:	www-apps/postfixadmin-{2.3.8,3.0.2,3.1}: Rename maildirmake to courier-maildirmake in mailbox creation script
Product:	Gentoo Linux	Reporter:	Luke Bratch <luke>
Component:	Current packages	Assignee:	Aaron W. Swenson <titanofold>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	gentoobugs, jstein, mjo, web-apps
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to rename maildirmake to courier-maildirmake Patch to rename maildirmake to courier-maildirmake

Description Luke Bratch 2018-01-08 19:45:42 UTC

Created attachment 513826 [details, diff]
Patch to rename maildirmake to courier-maildirmake

Hello

The ADDITIONS/postfixadmin-mailbox-postcreation.sh script in www-apps/postfixadmin calls the maildirmake command provided by net-mail/courier-imap, however maildirmake was renamed by:

commit da8c6dde5207a230c73ad433e417f1772697a81a
Author: Michael Orlitzky <mjo@gentoo.org>
Date:   Mon Mar 27 01:06:18 2017 -0400

    net-mail/courier-imap: new EAPI=6 version to fix a few bugs.

https://gitweb.gentoo.org/repo/gentoo.git/commit/net-mail/courier-imap?id=da8c6dde5207a230c73ad433e417f1772697a81a

This causes the script to fail.

The attached patch renames the call to maildirmake for all three versions of www-apps/postfixadmin in Portage.

Thanks
Luke

Comment 1 Aaron W. Swenson gentoo-dev

2018-01-31 12:25:16 UTC

(In reply to Luke Bratch from comment #0)
> The attached patch renames the call to maildirmake for all three versions of
> www-apps/postfixadmin in Portage.
> 
> Thanks
> Luke

Thanks for you work on this.

However, I'm not sure this is the best course to take.

I think net-mail/courier-imap should manage a symlink as, most likely, other scripts and/or packages may be broken by the rename.

There's no maintainer for net-mail/courier-imap, but I think we can get a consensus on what to do.

In the meantime, as for your patch, that work should not be done in src_unpack but in src_prepare. Would you rework it please?

Comment 2 Michael Orlitzky gentoo-dev

2018-01-31 20:40:32 UTC

Sorry =(

I renamed the binary because mail-mta/netqmail already installs a "maildirmake", so you couldn't use netqmail and courier-imap at the same time.

The right way to do it would probably be with eselect, but that feels like overkill.

Comment 3 Luke Bratch 2018-01-31 21:26:12 UTC

Created attachment 517308 [details, diff]
Patch to rename maildirmake to courier-maildirmake

(In reply to Aaron W. Swenson from comment #1)
> In the meantime, as for your patch, that work should not be done in
> src_unpack but in src_prepare. Would you rework it please?

No problem, I've made that change, please see the attached patch.

I've also added an extra sed to correct the name in the failure message and changed the commit message to look more like other commits in Portage.

As for net-mail/courier-imap, I agree that eselect feels overkill, but I'm not sure how else to deal with the conflict.

Comment 4 Aaron W. Swenson gentoo-dev

2018-02-23 12:37:18 UTC

*** Bug 643408 has been marked as a duplicate of this bug. ***