Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 643896

Summary: dev-db/redis-4.0.6 init script improvements
Product: Gentoo Linux Reporter: Patrick Lauer <patrick>
Component: Current packagesAssignee: Sam James <sam>
Status: RESOLVED OBSOLETE    
Severity: normal CC: hydrapolic, robbat2
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Patrick Lauer gentoo-dev 2018-01-08 13:24:44 UTC
The init script currently sets

pidfile=${REDIS_PID:-/run/redis/redis.pid}

and then later does

start_pre() {
        checkpath -d -m 0775 -o ${REDIS_USER}:${REDIS_GROUP} $(dirname ${REDIS_PID})
}

if for some reason REDIS_PID is unset $pidfile has a value, but checkpath/dirname gets confused and the init script refuses to run.

It would be easier to set:

REDIS_PID=${REDIS_PID:-/run/redis/redis.pid}

and then replace $pidfile with $REDIS_PID everywhere
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-02 04:31:40 UTC
It looks like this got fixed at some point along the way. We don't define start_pre at all now.