Bug 642956

Summary:	app-admin/qtpass version bump request
Product:	Gentoo Linux	Reporter:	Maciej S. Szmigiero <mail>
Component:	Current packages	Assignee:	Vladimir Pavljuchenkov (SpiderX) <spiderx>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dschridde+gentoobugs, jstein, proxy-maint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/6794
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch to disable building tests

Description Maciej S. Szmigiero 2018-01-01 12:52:19 UTC

app-admin/qtpass is currently at version 1.2.0, but the version in tree is still
1.1.6.

While bumping it it would be good to also include this commit from the current
master:
https://github.com/IJHack/QtPass/commit/190556b895beec232b30199f37cbc3fcfa0dde13
to prevent the package from leaking passwords to terminal.

I was able to build version 1.2.0 by renaming the 1.1.6 ebuild appropriately,
adding a small patch (attached to this bug) to skip building tests while still
keeping proper inter-directory dependencies (plus a patch containing the above commit).

BTW. I also get a QA warning about a missing "newicon" command, it looks like the
ebuild should inherit eutils for this command to work.

Comment 1 Maciej S. Szmigiero 2018-01-01 12:53:15 UTC

Created attachment 512500 [details, diff]
patch to disable building tests

Comment 2 Jonas Stein gentoo-dev

2018-01-01 20:17:13 UTC

see also
https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI

Comment 3 Dennis Schridde 2018-01-15 20:27:52 UTC

It appears that Gentoo now ships 1.2.1 in the main repository.

Comment 4 Maciej S. Szmigiero 2018-01-15 22:32:23 UTC

(In reply to Dennis Schridde from comment #3)
> It appears that Gentoo now ships 1.2.1 in the main repository.

It had been provisionally bumped due to security vulnerability, but
the final (improved) ebuild from the pull request pointed by the "See Also" field
of this bug hasn't been committed yet (it is tagged to close this bug).

Comment 5 Vincent-Xavier JUMEL 2018-05-14 18:49:07 UTC

Here's a release that fix https://bugs.gentoo.org/642956 : https://github.com/IJHack/QtPass/releases/tag/v1.2.2

Comment 6 Vladimir Pavljuchenkov (SpiderX) 2018-05-15 17:46:31 UTC

Thank you for noticing.
Another commit with 1.2.2 inside the same PR created and it is waiting for review.

Comment 7 Larry the Git Cow gentoo-dev

2018-05-16 08:18:41 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dbce389e48b0996f21c14cd44a8492bcc5581f93

commit dbce389e48b0996f21c14cd44a8492bcc5581f93
Author:     Vladimir Pavljuchenkov (SpiderX) <spiderx@spiderx.dp.ua>
AuthorDate: 2018-05-15 17:37:04 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-05-16 08:17:43 +0000

    app-admin/qtpass: 1.2.2 version bump
    
    1. Sorted in alphabetical order eclasses, keywords.
    2. Added USE-flag test.
    3. Fixed dependencies and src_prepare section.
    4. Fixed tests installation (patches are in upstream).
    5. Added installation of appdata.
    6. Added localization support (l10n eclass).
    
    Closes: https://bugs.gentoo.org/643526
    Closes: https://bugs.gentoo.org/642956
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    Closes: https://github.com/gentoo/gentoo/pull/6794

 app-admin/qtpass/Manifest            |  1 +
 app-admin/qtpass/qtpass-1.2.2.ebuild | 74 ++++++++++++++++++++++++++++++++++++
 2 files changed, 75 insertions(+)