|Summary:||<media-libs/libffado-2.4.0 optionally depends on deprecated dev-python/PyQt4|
|Product:||Gentoo Linux||Reporter:||Andreas Sturmlechner <asturm>|
|Component:||Current packages||Assignee:||Hector Martin <marcan>|
|Severity:||normal||CC:||proaudio, proxy-maint, xavier.forestier|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
Description Andreas Sturmlechner 2017-12-28 15:55:19 UTC
Qt4 is dead and going away, please check if this functionality can be built with Qt5 instead already. Otherwise, if upstream is not going to port it to Qt5, consider dropping the USE flag.
Comment 1 Hector Martin 2017-12-28 17:32:30 UTC
libffado-2.4.0 was released a couple days ago and should support python3/qt5. I need/can test the optional functionality, but I'm away from the hardware until the second week of January. I'll bump and test the qt5 support then.
Comment 2 Xavier Forestier 2018-01-01 15:29:27 UTC
Please note I code huge patches for Python 3 / PyQT5 + updated ebuild few month ago: https://github.com/xavierforestier/ffado/tree/master/media-libs/libffado I fix the patch few days ago : ffado dev includes most my changes but forget some :-/ 2.3.9999 works fine with last SVN commit 2723 and following dependencies : - dev-python/PyQt5-5.9.2 - dev-lang/python-3.6.3-r1 - media-sound/jack2-1.9.12 (patched in my overlay to enable libffado)
Comment 3 Andreas Sturmlechner 2018-01-01 16:19:01 UTC
Nicely done! I see your overlay ebuild is still EAPI 5 so seems to be based off an outdated version from tree. Could you have a look at that and sync with in-tree status, drop USE=qt4 and submit a PR (or a unified diff here, as you prefer)? In case 2.4.0 needs more patching we can always include that, but did you already submit a new PR for upstream?
Comment 4 Xavier Forestier 2018-01-02 22:40:17 UTC
(In reply to Andreas Sturmlechner from comment #3) > Nicely done! I see your overlay ebuild is still EAPI 5 so seems to be based > off an outdated version from tree. Could you have a look at that and sync > with in-tree status, drop USE=qt4 and submit a PR (or a unified diff here, > as you prefer)? > > In case 2.4.0 needs more patching we can always include that, but did you > already submit a new PR for upstream? I'm brand new to GIT and forking stuffs, I hope I made things right :) I've checked changes made on in-official-tree on ebuild (nothing is really usefull, or obsolete with changes made on source code), I remove QT4 useflag as requested, and (try to) submit a PR: https://github.com/gentoo/gentoo/pull/6724 I create 4 separated ebuild : 2.9999 stands for trunks SVN 2.3.9999 stands for 2.3.x SVN branch 2.4.9999 stands for 2.4.x SVN branch 2.4.0 tar.gz sources All ebuild are copies of each others.
Comment 5 Hector Martin 2018-01-11 02:42:00 UTC
(In reply to Xavier Forestier from comment #4) > (In reply to Andreas Sturmlechner from comment #3) > > Nicely done! I see your overlay ebuild is still EAPI 5 so seems to be based > > off an outdated version from tree. Could you have a look at that and sync > > with in-tree status, drop USE=qt4 and submit a PR (or a unified diff here, > > as you prefer)? > > > > In case 2.4.0 needs more patching we can always include that, but did you > > already submit a new PR for upstream? > > I'm brand new to GIT and forking stuffs, I hope I made things right :) > > I've checked changes made on in-official-tree on ebuild (nothing is really > usefull, or obsolete with changes made on source code), I remove QT4 useflag > as requested, and (try to) submit a PR: > https://github.com/gentoo/gentoo/pull/6724 > > I create 4 separated ebuild : > 2.9999 stands for trunks SVN > 2.3.9999 stands for 2.3.x SVN branch > 2.4.9999 stands for 2.4.x SVN branch > 2.4.0 tar.gz sources > > All ebuild are copies of each others. Thanks for the contribution! I'm testing and reviewing 2.4.0 now and will report back. May I suggest that perhaps the live ebuilds would find a better home in the audio-overlay ? I feel like perhaps it's not worth the overhead in keeping those alive and tested in portage as the upstream trees change.  https://github.com/gentoo-audio/audio-overlay/
Comment 6 Hector Martin 2018-01-11 03:33:38 UTC
Looks like there are more things broken with Python 3 (the submitted ebuild is sufficient to compile, but not run, ffado-mixer). Since the ebuild is not based on the more up-to-date ebuild already in portage, I'm putting together a new one based on some of the proposed patches, stuff already upstream, and new patches to make things actually work (which I'll send upstream).
Comment 7 Hector Martin 2018-01-11 04:43:31 UTC
PR for 2.4.0: https://github.com/gentoo/gentoo/pull/6826
Comment 8 Larry the Git Cow 2018-01-11 23:57:39 UTC
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=087ba48a1b12b4ca931ee1e3bbb6e1fc332dca33 commit 087ba48a1b12b4ca931ee1e3bbb6e1fc332dca33 Author: Hector Martin <email@example.com> AuthorDate: 2018-01-11 04:11:52 +0000 Commit: Andreas Sturmlechner <firstname.lastname@example.org> CommitDate: 2018-01-11 23:57:27 +0000 media-libs/libffado: bump to 2.4.0 and switch to qt5 Bug: https://bugs.gentoo.org/642530 Closes: https://github.com/gentoo/gentoo/pull/6826 media-libs/libffado/Manifest | 1 + .../libffado-2.4.0-additional-py3-fixes.patch | 96 ++++++++++ .../files/libffado-2.4.0-crossbar-router-fix.patch | 11 ++ .../files/libffado-2.4.0-py3-pyqt5-fixes.patch | 197 +++++++++++++++++++++ .../libffado-2.4.0-pyqt5-dbus-detection.patch | 30 ++++ .../files/libffado-2.4.0-rme-bigendian-fix.patch | 50 ++++++ media-libs/libffado/libffado-2.4.0.ebuild | 119 +++++++++++++ 7 files changed, 504 insertions(+)}
Comment 9 Andreas Sturmlechner 2018-01-11 23:59:08 UTC
Thanks! Please test and decide when we can cleanup old.
Comment 10 Andreas Sturmlechner 2018-01-19 18:09:54 UTC
@Hector: ping, is 2.3.0 good to go?
Comment 11 Bignaux Ronan 2018-01-23 03:06:10 UTC
2.3.0 doesn't compile on recent system anyway. 2.4.0 with qt5 provides ffado-mixer, but i don't get it working with my FA-66 . With python2.7, i've console log and qt log widget working (but no sound change), no output with python3 ... i'm investigating. Btw, the driver works with jack (i use jack2 from GentooStudio overlay). It way more stable than use alsa firewire driver.
Comment 12 Larry the Git Cow 2018-01-23 10:56:27 UTC
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17ed34d641046efcfedff475eb6dc7af409e33cb commit 17ed34d641046efcfedff475eb6dc7af409e33cb Author: Andreas Sturmlechner <email@example.com> AuthorDate: 2018-01-23 10:40:34 +0000 Commit: Andreas Sturmlechner <firstname.lastname@example.org> CommitDate: 2018-01-23 10:41:05 +0000 media-libs/libffado: Drop old Closes: https://bugs.gentoo.org/642530 Package-Manager: Portage-2.3.19, Repoman-2.3.6 media-libs/libffado/Manifest | 1 - .../libffado/files/libffado-2.3.0-gcc6.patch | 26 ----- .../files/libffado-2.3.0-include-signal.patch | 29 ------ .../files/libffado-2.3.0-modelname-strip.patch | 45 --------- media-libs/libffado/libffado-2.3.0.ebuild | 107 --------------------- media-libs/libffado/metadata.xml | 1 - 6 files changed, 209 deletions(-)
Comment 13 Hector Martin 2018-01-23 11:38:24 UTC
Sorry, I missed the ping. I was waiting for PR #6911 to go through to call it a day, but if it's broken thanks for getting rid of it now. @Bignaux Ronan please file another bug for your issue. libffado supports a rather diverse set of hardware and upstream's main developer still is still on Python2/Qt4; I can only test the hardware I have (Focusrite Saffire Pro 26), so we're relying on user reports to debug and fix any Py3/Qt5 breakage with specific hardware at this point.