Summary: | net-libs/signond installs without SecretsStorage backend, falls back to unencrypted plain-text SQLite DB | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Martijn Schmidt <martijn.schmidt> |
Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | martijn.schmidt |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
signond-8.59-r1.ebuild
metadata.xml signond-ebuild.diff signond-metadata.diff kaccounts-integration-ebuild.diff kaccounts-integration-metadata.diff |
Description
Martijn Schmidt
2017-12-27 16:49:32 UTC
Created attachment 511766 [details]
metadata.xml
Thanks for your report, it is always better if you attach unified diffs over the most recent ebuild instead of the full ebuild, so your changes can be reviewed. Created attachment 511880 [details, diff]
signond-ebuild.diff
Thanks for the hint, I wasn't aware that a different format is preferred. I have attached the unified diffs you've asked for your review and obsoleted the old attachments.
Created attachment 511882 [details, diff]
signond-metadata.diff
Created attachment 512680 [details, diff]
kaccounts-integration-ebuild.diff
The ebuild which I proposed last week results in circular dependencies on a system which doesn't already have both packages installed. Please excuse the newbie mistake on my part! ;-)
===========
* Error: circular dependencies:
(net-libs/signond-8.59-r1:0/0::local, ebuild scheduled for merge) depends on
(kde-apps/signon-kwallet-extension-17.12.0:5/5::gentoo, ebuild scheduled for merge) (runtime)
(net-libs/signond-8.59-r1:0/0::local, ebuild scheduled for merge) (buildtime)
* Note that circular dependencies can often be avoided by temporarily
* disabling USE flags that trigger optional dependencies.
===========
Perhaps the cleaner solution, in this case, would be to modify the ebuild for kde-apps/kaccounts-integration so that it has a kwallet USE flag with an RDEPEND on kde-apps/signon-kwallet-extension when enabled. This was the upstream's recommended setup, and for users with the desktop/plasma profile the kwallet USE flag is going to be enabled by default anyway.
That'll leave the Gnome team to decide what they'd like to do for the net-libs/signond integration with signon-keyring-extension. I'm not sure what'd be the best approach for other projects which may depend on net-libs/signond.
Created attachment 512682 [details, diff]
kaccounts-integration-metadata.diff
I'm not sure about the best course of action here. Portage does not really support optional runtime deps, and USE flags exclusively in RDEPEND are frowned upon. If we add it unconditionally, definitely some people will complain. Until there is real support for it in Portage we typically solve situations like these via an elog/optfeature message in pkg_postinst. Right now we have the following dependency chain: kde-apps/plasma-telepathy-meta kde-apps/ktp-kded-module kde-apps/signon-kwallet-extension |