Summary: | sci-geosciences/googleearth Re-introduce to the tree | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Martijn Schmidt <martijn.schmidt> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | ab4bd, aliaksei.urbanski, einfair, espinafre, jstein, martijn.schmidt, martin, mgorny, mmokrejs, mschiff, orzel |
Priority: | Normal | Keywords: | EBUILD, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=624966 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild for googleearth-7.1.8.3036 under the new pro release scheme
modified desktopfile patch to account for the new pro release scheme original googleearth-mimetypes.xml to be installed into filesdir googleearth-7.1.8.3036.ebuild googleearth-7-pro-desktopfile.patch googleearth-mimetypes.xml metadata.xml Manifest googlearth-7.1.8.3036.ebuild googlearth-7.1.8.3036.ebuild googleearth-7.1.8.3036.ebuild |
Description
Martijn Schmidt
2017-12-26 16:45:50 UTC
Created attachment 511662 [details, diff]
modified desktopfile patch to account for the new pro release scheme
Created attachment 511664 [details]
original googleearth-mimetypes.xml to be installed into filesdir
Created attachment 511666 [details]
googleearth-7.1.8.3036.ebuild
Created attachment 511668 [details, diff]
googleearth-7-pro-desktopfile.patch
Created attachment 511670 [details]
googleearth-mimetypes.xml
Created attachment 511672 [details]
metadata.xml
Created attachment 511674 [details]
Manifest
Created attachment 511950 [details] googlearth-7.1.8.3036.ebuild The original ebuild (from the gentoo repository) needs some updates which are fixed in the attached ebuild: 1. /lib/ld-linux-x86-64.so.2 does not exist in amd64/17.1 profile: /$(get_libdir)/ld-linux-x86-64.so.2 should be used instead, see bug 642574 2. Update the ebuild to EAPI=6 3. Do not rely on eutils.eclass inheriting desktop.eclass 4. gdal-1 is no longer in the gentoo repository, hence cannot be unbundled 5. Now that upstream has versioned tarballs, there is no need to rename the tarballs locally -> keep upstream names (In reply to Martin Väth from comment #8) > Created attachment 511950 [details] > googlearth-7.1.8.3036.ebuild > > The original ebuild (from the gentoo repository) needs some updates which > are fixed in the attached ebuild: Thanks Martin, your ebuild appears to be better than mine so I have obsoleted the previous one. Should we also get rid of the pkg_nofetch() messages now that we don't have to grab the "current" release from the upstream anymore? Or just replace it with a shorter message such as the following? "Note that Gentoo cannot mirror the distfiles due to license reasons." I am not sure how reliably google will actually increase the version in case of trivial changes. If you think that it is safe, it can be removed completely. I would not keep not a shorter version. BTW, in the moment I maintain a current version (including googleearth-7.3.0.3832) in the mv overlay. Created attachment 512058 [details]
googlearth-7.1.8.3036.ebuild
Update of ebuild:
Use xdm-utils.eclass instead of obsolete fdo-mime.eclass.
Remove nofetch message
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: • Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman • Please introduce local variables with "local" • Please remember to update the header, while at it • Please remove obsolete attachments • Please check, if you really need eutils here Do you want to (proxy) maintain it? Created attachment 513144 [details]
googleearth-7.1.8.3036.ebuild
(In reply to Jonas Stein from comment #12) > Do you want to (proxy) maintain it? I suppose you mean both Martijn and me (whoever is volunteering…) Due to my past (and again recent) experience with mgorny, I will not proxy-maintain anything. In the moment, I keep and update the ebuilds in the mv overlay. (As mentioned, there is already an ebuild for the differently bundled googleearth-7.3.0…3832). Feel free to pick from there whatever you want, but I will not be a proxy-maintainer. > I had a short look on the ebuild. I actually did not look at it so carefully, because it was previously in the tree. So I had expected that it was written carefully and only checked what changes of portage/eclassed happened since its removal. > • Please test the ebuild with repoman full -x This was tested in the moment when I put it in the mv overlay (before I posted the second version). > • Please introduce local variables with "local" Surprisingly, this was indeed forgotten for "size" already in the original ebuild. > • Please remember to update the header, while at it Thanks for the reminder. BTW, happy new year! > • Please remove obsolete attachments I am always hesitating to mark attachments as obsolete, because then it is impossible to check the changes. > • Please check, if you really need eutils here I had already done so: It is needed because of make_wrapper. Anyway, I had overlooked that "epatch" should be replaced by "eapply -p0" now that the ebuild is EAPI=6. Hi, shall I use the ebuikld from pg_overlay or from mv_overlay or funtoo or multilib-poratge as of now? Thank you https://gpo.zugaina.org/sci-geosciences/googleearth Shouldn't sci-geosciences/googleearth be renamed to sci-geosciences/googleearth-bin actually? BTW, is https://github.com/google/earthenterprise doing same thing? It's been a long time since googleearth was available in the main tree, it is missed, badly. SO badly ! Please bring Google Earth Pro back please! Merry Christmas! |