| Summary: | media-sound/mpd-0.20.12[cdio] with dev-libs/libcdio-1.1.0 - src/archive/plugins/Iso9660ArchivePlugin.cxx:118:32: error: too few arguments to function ‘void _cdio_list_free(CdioList_t*, int, CdioDataFree_t)’ | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andreas Proteus <proteuss> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 1i5t5.duncan, atoth, jstein, leonchik1976, nrndda, sound, steven |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/MusicPlayerDaemon/MPD/issues/173 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
media-sound:mpd-0.20.12:20171214-194410.log
Output of emerge --info |
||
Created attachment 510072 [details]
Output of emerge --info
Are you sure you mean libcdio-1.0.0? Because I'm seeing the same build error here, attempting to build against the new libcdio-1.1.0. But as it happens I run with FEATURES=buildpkg, so I had an old libcdio-1.0.0-r1 binpkg to revert to, and sure enough, mpd builds against it just fine. So if you don't mean libcdio-1.1.0 breaks and libcdio-1.0.0(-r1) is fine, I'm confused! Duncan @Duncan Fixed the title. My mistake. Indeed I meant libcdio-1.1.0 Given that URL, and from it the fact that upstream mpd has now removed cdio support going forward, it would seem the best fix here would be to either mask the flag or remove it, and the cdio deps, entirely, as well. (In reply to Duncan from comment #4) > Given that URL, and from it the fact that upstream mpd has now removed cdio > support going forward, it would seem the best fix here would be to either > mask the flag or remove it, and the cdio deps, entirely, as well. Of course the (temporary) alternative would be to mask libcdio-1.1.0, since as discussed at the above URL, it contains an API-break without a corresponding major version and *.so version bump. But at least for mpd that's temporary, as upstream mpd seems to be removing support now, so the option won't exist for the next version anyway. Github for MPD has a fix for this. at about line 118 of src/archive/plugins/Iso9660ArchivePlugin.cxx #if LIBCDIO_VERSION_NUM >= 20000 iso9660_filelist_free(entlist); #else _cdio_list_free (entlist, true); #endif The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79b15a0228e634e9418706ff8b27d21ced8ba0ee commit 79b15a0228e634e9418706ff8b27d21ced8ba0ee Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-08-15 12:56:54 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-08-15 13:20:04 +0000 media-sound/mpd: Fix build with >=dev-libs/libcdio-2 Closes: https://bugs.gentoo.org/641078 Package-Manager: Portage-2.3.46, Repoman-2.3.10 media-sound/mpd/files/mpd-0.20.10-libcdio-2.patch | 27 +++++++++++++++++++++++ media-sound/mpd/mpd-0.20.10.ebuild | 1 + media-sound/mpd/mpd-0.20.12-r2.ebuild | 5 ++++- 3 files changed, 32 insertions(+), 1 deletion(-) |
Created attachment 510070 [details] media-sound:mpd-0.20.12:20171214-194410.log It builds ok if USE="-cdio