Summary: | dev-libs/tvision-2.2.1.4 : ../.../tdesktop.cc:151:29: error: call of overloaded abs(unsigned int) is ambiguous | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Bernd <waebbl-gentoo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint, waebbl-gentoo |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/12245 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge-info.txt
dev-libs:tvision-2.2.1.4:20171202-104255.log emerge-history.txt environment etc.portage.tbz2 logs.tbz2 temp.tbz2 fix abs error in >=gcc-6 |
Description
Toralf Förster
2017-12-02 10:48:46 UTC
Created attachment 507662 [details]
emerge-info.txt
Created attachment 507664 [details]
dev-libs:tvision-2.2.1.4:20171202-104255.log
Created attachment 507666 [details]
emerge-history.txt
Created attachment 507668 [details]
environment
Created attachment 507670 [details]
etc.portage.tbz2
Created attachment 507672 [details]
logs.tbz2
Created attachment 507674 [details]
temp.tbz2
I look into this when I got the transition to 17.0 ready. It looks like an easy to fix bug, I encountered with 6.4.0 too but in different files. Created attachment 547350 [details, diff] fix abs error in >=gcc-6 This patch solves the compile issue with >gcc-6. It replaces the use of unsigned with int at places where abs is used. But I don't know the exact impact on the library or existing applications, because I don't have a real world example application to test with. The patch also replaces the ${FILESDIR}/${P}-gcc6.patch file. The use of std::abs is no longer necessary. I filed a bug upstream, see https://sourceforge.net/p/tvision/bugs/17/ but got no response yet. Still no response from upstream, after 30 days. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f524f5217331b84965e484eded8b5271b907fb6b commit f524f5217331b84965e484eded8b5271b907fb6b Author: Bernd Waibel <waebbl@gmail.com> AuthorDate: 2019-06-12 12:04:40 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2019-07-05 14:23:57 +0000 dev-libs/tvision: fix gcc-7 incompatibilities With gcc-7, they way overloaded functions are handled has changed, which led to build failures. This has been addressed by upstream, see https://sourceforge.net/p/tvision/bugs/17/ Closes: https://bugs.gentoo.org/639492 Package-Manager: Portage-2.3.67, Repoman-2.3.14 Signed-off-by: Bernd Waibel <waebbl@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/12245 Signed-off-by: Michał Górny <mgorny@gentoo.org> .../files/tvision-2.2.1.4-fix-overloaded-abs.patch | 100 +++++++++++++++++++++ dev-libs/tvision/tvision-2.2.1.4.ebuild | 17 ++-- 2 files changed, 108 insertions(+), 9 deletions(-) |