| Summary: | net-misc/quagga-1.2.1: test failures on sparc | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Rolf Eike Beer <eike> |
| Component: | Current packages | Assignee: | Sergey Popov (RETIRED) <pinkbyte> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | TESTFAILURE |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://gogs.quagga.net/Quagga/quagga/commit/adda534f95ec87206c9dfd1b3bae05221dc29730 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build.log | ||
Created attachment 506746 [details]
build.log
What does that mean? Ignore those errors and stabilize it anyway? (In reply to Rolf Eike Beer from comment #2) > What does that mean? Ignore those errors and stabilize it anyway? Testing errors can not prevent security stabilization per our policy It's actually not a testcase error, but a real code error. This is the fix:
diff --git a/bgpd/bgp_open.c b/bgpd/bgp_open.c
index 28004230..d9ec4bef 100644
--- a/bgpd/bgp_open.c
+++ b/bgpd/bgp_open.c
@@ -120,7 +120,8 @@ bgp_capability_vty_out (struct vty *vty, struct peer *peer)
static void
bgp_capability_mp_data (struct stream *s, struct capability_mp_data *mpc)
{
- mpc->afi = stream_getw (s);
+ afi_t afi = stream_getw (s);
+ memcpy(&mpc->afi, &afi, sizeof(mpc->afi));
mpc->reserved = stream_getc (s);
mpc->safi = stream_getc (s);
}
Fix is upstream, should be in next (point) release. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab71ee7a03166f69b15849ab336ed5056aa0b8d0 commit ab71ee7a03166f69b15849ab336ed5056aa0b8d0 Author: Sergey Popov <pinkbyte@gentoo.org> AuthorDate: 2018-01-25 16:03:14 +0000 Commit: Sergey Popov <pinkbyte@gentoo.org> CommitDate: 2018-01-25 16:03:28 +0000 net-misc/quagga: revision bump Backport fixes for test failures on sparc and incorrect ipv6 route handling Closes: https://bugs.gentoo.org/638906 Closes: https://bugs.gentoo.org/641736 Package-Manager: Portage-2.3.19, Repoman-2.3.6 net-misc/quagga/files/quagga-1.2.2-ipv6-bgp.patch | 42 +++++++ .../quagga/files/quagga-1.2.2-sparc-tests.patch | 31 +++++ net-misc/quagga/quagga-1.2.2-r1.ebuild | 137 +++++++++++++++++++++ 3 files changed, 210 insertions(+) Just for the record: this was no test bug, but a real library bug. (In reply to Rolf Eike Beer from comment #7) > Just for the record: this was no test bug, but a real library bug. We know that(actually it was pretty clear from your patch draft - it did not fix testsuite, but the actual code), but we prefer to stick with upstream decision - commit adda534f95ec87206c9dfd1b3bae05221dc29730 says only about test failures. |
=== libzebra tests === Using /usr/share/dejagnu/config/unix.exp as generic interface file for target. Using ./config/unix.exp as tool-and-target-specific interface file. Running ./bgpd.tests/aspathtest.exp ... Running ./bgpd.tests/ecommtest.exp ... Running ./bgpd.tests/testbgpcap.exp ... failed: testbgpcap ORF: ORF, simple, single entry, single tuple -- testbgpcap aborted! Running ./bgpd.tests/testbgpmpath.exp ... Running ./bgpd.tests/testbgpmpattr.exp ... Portage 2.3.8 (python 2.7.14-final-0, default/linux/sparc/13.0, gcc-6.4.0, glibc-2.25-r9, 4.14.2 sparc64) ================================================================= System Settings ================================================================= System uname: Linux-4.14.2-sparc64-sun4v-with-gentoo-2.3 KiB Mem: 33133616 total, 21389848 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Sun, 26 Nov 2017 01:15:01 +0000 Head commit of repository gentoo: 57d39d4794da75dd7469590e964f83336f64acd1 sh bash 4.3_p48-r1 ld GNU ld (Gentoo 2.28.1 p1.0) 2.28.1 app-shells/bash: 4.3_p48-r1::gentoo dev-lang/perl: 5.24.3::gentoo dev-lang/python: 2.7.14::gentoo, 3.4.5::gentoo, 3.5.4::gentoo dev-util/cmake: 3.8.2::gentoo dev-util/pkgconfig: 0.29.2::gentoo sys-apps/baselayout: 2.3::gentoo sys-apps/openrc: 0.34.9::gentoo sys-apps/sandbox: 2.10-r4::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69::gentoo sys-devel/automake: 1.10.3-r2::gentoo, 1.11.6-r2::gentoo, 1.12.6-r1::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15.1-r1::gentoo sys-devel/binutils: 2.28.1::gentoo sys-devel/gcc: 5.4.0-r3::gentoo, 6.4.0::gentoo sys-devel/gcc-config: 1.8-r1::gentoo sys-devel/libtool: 2.4.6-r3::gentoo sys-devel/make: 4.2.1::gentoo sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers) sys-libs/glibc: 2.25-r9::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 ACCEPT_KEYWORDS="sparc" ACCEPT_LICENSE="* -@EULA" CBUILD="sparc-unknown-linux-gnu" CFLAGS="-O2 -mcpu=niagara2 -pipe" CHOST="sparc-unknown-linux-gnu" CONFIG_PROTECT="/etc /etc/omega.conf /usr/share/gnupg/qualified.txt /var/spool/torque" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.0/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.0/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -mcpu=niagara2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="" GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j20" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl berkdb big-endian bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 modules ncurses nls nptl openmp pam pcre readline session sparc ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21 ruby22" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= net-misc/quagga-1.2.1::gentoo was built with the following: USE="bgpclassless caps doc fpm ipv6 multipath nhrpd ospfapi pam protobuf readline snmp tcp-zebra" CFLAGS="-O2 -mcpu=niagara2 -pipe -fno-strict-aliasing" CXXFLAGS="-O2 -mcpu=niagara2 -pipe -fno-strict-aliasing" Reproducible: Always