Bug 638456 – net-libs/nodejs USE="-icu -ssl" disables support for inspector

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Rodrigo Saboya 2017-11-22 16:42:45 UTC]

Since Node 8, icu and ssl are required to use the v8 inspector. Since this isn't mentioned anywhere, it might be confusing for some users to try to use the debugger and get this message:

Inspector support is not available with this Node.js build

Because icu isn't enabled.

This bug was created because of this PR:
https://github.com/gentoo/gentoo/pull/6218

The PR adds a inspector USE flag with the correct REQUIRED_USE, and sets +icu and +inspector by default. I believe it's the common use case to have the inspector enabled by default.

Reproducible: Always

Steps to Reproduce:
1. emerge nodejs
2. Try to use the debugger
3.
Actual Results:  
Debugger works

Expected Results:  
Inspector support is not available with this Node.js build

[Comment 1 Rodrigo Saboya 2017-11-22 16:45:00 UTC]

"Actual results" and "Expected results" are swapped, sorry about that.

[Comment 2 Jeroen Roovers (RETIRED) 2017-11-22 17:16:44 UTC]

Why do you suggest adding even more USE flags instead of just describing the current ones properly?

[Comment 3 Rodrigo Saboya 2017-11-22 20:02:42 UTC]

From a usability point of view, I think it's counter-intuitive. ICU and SSL offer features that are not tied to the v8 inspector.

From a customizability point of view, it allows for inspector to be disabled while still using ICU and SSL, which might be useful for production usage.

[Comment 4 Jeroen Roovers (RETIRED) 2017-11-23 00:03:11 UTC]

(In reply to Rodrigo Saboya from comment #3)
> From a customizability point of view, it allows for inspector to be disabled
> while still using ICU and SSL, which might be useful for production usage.

Fair point.

[Comment 5 Jeroen Roovers (RETIRED) 2017-11-25 06:36:56 UTC]

I added USE=inspector in 8.9.1-r1 and 9.2.0-r1.