Summary: | games-emulation/dolphin-5.0 fix build error with gcc 6.2 (ish) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sander Sweers <Sander.Sweers> |
Component: | Current packages | Assignee: | Devan Franchini (RETIRED) <twitch153> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fhlfibh, gentoo-bugs, jason.oliveira, jb.faq, lahvuun, toralf |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/dolphin-emu/dolphin/commit/1963996dd068a081f14fa12f364e9cdf8cd52a41 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 582084 | ||
Attachments: |
gcc 6.2 build fix
ebuild with Sander Sweers's modifications |
Description
Sander Sweers
2017-11-18 09:45:21 UTC
Needed for gcc 7, too *** Bug 620446 has been marked as a duplicate of this bug. *** I can confirm the changes result in a successful build, and I was able to play a few rounds in a game without any issues. Sorry, did not notice bug 620446 and had a fix :( works for me too, please add this patch to the tree Patch works for me too. I'm using gcc-4.9.4 still, so the error appears unrelated to which gcc version is in use. This build error is completely unrelated to GCC. The problem is with glibc-2.25, specifically the header file <limits.h> which in this exact version got a new #define directive, CHAR_WIDTH. Dolphin's source code defines a constant with the same name, and so the compiler tries to create a variable with name "8", which is not allowed, and that triggers the build failure. Sander Sweers' patch works in the 5.0 ebuild on my systems. Please merge, so that Dolphin is buildable again post-glibc updates. Thanks. Created attachment 512100 [details]
ebuild with Sander Sweers's modifications
To save the maintainer time, just use this ebuild. All credit goes to Sander Sweers for the changes.
(In reply to Jason Oliveira from comment #9) > Created attachment 512100 [details] > ebuild with Sander Sweers's modifications > > To save the maintainer time, just use this ebuild. All credit goes to Sander > Sweers for the changes. This worked for me, together with the modified cflags described in bug 640124 *** Bug 638156 has been marked as a duplicate of this bug. *** *** Bug 620446 has been marked as a duplicate of this bug. *** The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef8bb10ad88faeaf84a9ff6133507413618bd41d commit ef8bb10ad88faeaf84a9ff6133507413618bd41d Author: David Seifert <soap@gentoo.org> AuthorDate: 2018-01-11 10:24:41 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2018-01-11 10:35:38 +0000 games-emulation/dolphin: Fix building with new glibc Closes: https://bugs.gentoo.org/637986 Package-Manager: Portage-2.3.19, Repoman-2.3.6 games-emulation/dolphin/dolphin-5.0.ebuild | 64 ++++++++-------------- .../files/dolphin-5.0-CHAR_WIDTH-collision.patch | 49 +++++++++++++++++ 2 files changed, 72 insertions(+), 41 deletions(-) |