Summary: | sys-apps/portage-2.3.13: unused preserved libs not removed when emerge uninstalls a package due to blockers | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Zac Medico <zmedico> |
Component: | Core | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra, tsmksubc |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 240323, 637452 |
Description
Zac Medico
2017-11-12 22:20:44 UTC
It looks like the problem is that dblink.unmerge() calls self._prune_plib_registry() with no arguments, which then calls self._find_unused_preserved_libs(unmerge_no_replacement=False), but we really want unmerge_no_replacement=True behavior here. The lib_graph inside _find_unused_preserved_libs shows that it's using NEEDED.ELF.2 data from the libreoffice-5.2.7.2, even though the files now belong to libreoffice-bin-5.4.2.2 (which depend on liborcus-*0.12.so.0): ['/usr/lib64/libreoffice/program/libsclo.so'] depends on ['/usr/lib64/liborcus-parser-0.11.so.0', '/usr/lib64/liborcus-parser-0.11.so.0.0.0'] (0) ['/usr/lib64/liborcus-parser-0.11.so.0', '/usr/lib64/liborcus-parser-0.11.so.0.0.0'] (no children) ['/usr/lib64/liborcus-0.11.so.0', '/usr/lib64/liborcus-0.11.so.0.0.0'] depends on ['/usr/lib64/liborcus-parser-0.11.so.0', '/usr/lib64/liborcus-parser-0.11.so.0.0.0'] (0) ['/usr/lib64/libreoffice/program/libscfiltlo.so'] depends on ['/usr/lib64/liborcus-parser-0.11.so.0', '/usr/lib64/liborcus-parser-0.11.so.0.0.0'] (0) ['/usr/lib64/liborcus-0.11.so.0', '/usr/lib64/liborcus-0.11.so.0.0.0'] (0) The files from libreoffice-bin-5.4.2.2 actually depend on liborcus-0.12.so.0 Patch posted for review: https://archives.gentoo.org/gentoo-portage-dev/message/f22ad57a6dd166073ab8643854174f32 https://github.com/gentoo/portage/pull/227 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=0936d873aedccfb46ca4353c0b52f460287d6682 commit 0936d873aedccfb46ca4353c0b52f460287d6682 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2017-11-13 02:11:07 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2017-11-14 03:14:19 +0000 vardbapi.removeFromContents: update NEEDED (bug 637284) When removing files from CONTENTS, also remove the corresponding lines from NEEDED, so that they do not corrupt LinkageMap data for preserve-libs. Bug: https://bugs.gentoo.org/637284 Reviewed-by: Manuel RĂ¼ger <mrueg@gentoo.org> pym/portage/dbapi/vartree.py | 42 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 40 insertions(+), 2 deletions(-)} |