Summary: | media-sound/audacity-2.2.0[-id3tag] : export/ExportMP3.cpp:2013:22: error: id3_tag has not been declared | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Ameretat.Reith, ao, arnaudv6, contact, daniel.koszta, daniel, dfhayes, dharding, email200202, gentoo, gentoo, gentoo, harrisl, heiko.baums, hendrik, jarausch, jj, leonchik1976, mail, Manfred.Knick, Martin.vGagern, n-roeser, nholland, orzel, realnc, richard, silvio.gerli, v_2e, xaviermiller, zlg |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 logs.tbz2 media-sound:audacity-2.2.0:20171106-131641.log temp.tbz2 2.2.1-id3tag.patch |
Description
Toralf Förster
2017-11-06 18:10:59 UTC
Created attachment 502820 [details]
emerge-info.txt
Created attachment 502822 [details]
emerge-history.txt
Created attachment 502824 [details]
environment
Created attachment 502826 [details]
etc.portage.tbz2
Created attachment 502828 [details]
logs.tbz2
Created attachment 502830 [details]
media-sound:audacity-2.2.0:20171106-131641.log
Created attachment 502832 [details]
temp.tbz2
with USE=id3tag, it builds fine... Same problem here, same solution. Agreed that it builds fine with the id3tag USE flag enabled. If this is a requirement going forward, it should be enabled by default (or the USE flag should be removed). I added me in copy of said bug, but I wanted to thank you for bumping this quick. *** Bug 637124 has been marked as a duplicate of this bug. *** +1 on both id3tag fix and suggestion that if it's required it should be on by default. *** Bug 639292 has been marked as a duplicate of this bug. *** *** Bug 640178 has been marked as a duplicate of this bug. *** It appears that this is partly fixed in audacity-minsrc-2.2.1-rc3 sources. That is this config will create a buildable tree: ./configure --with-ffmpeg --with-lame --with-libid3tag However, if you omit --with-libid3tag you sill get the compile-time errors above. That suggests that either the code should be changed to compile without USE_LIBID3TAG defined, or that configure should insist that the user provide --with-libid3tag. Or perhaps --with-libid3tag should be the default, as mentioned above. I know nothing more. This should be fixed in upstream https://github.com/audacity/audacity/pull/230 and will be included in the next release aimed for end of January. Patch should apply 2.2.1 as well if someone wants to create an -r1 ebuild in the meantime. Created attachment 515328 [details, diff] 2.2.1-id3tag.patch Just adding the mentioned upstream commit in a form of a patch which may be used together with the ebuild from Bug 624264 containing some other fixes as well. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa8c4f250b9a44c2a30d47bf7351e5fba08dc794 commit fa8c4f250b9a44c2a30d47bf7351e5fba08dc794 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2018-02-18 11:13:03 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2018-02-18 11:13:03 +0000 media-sound/audacity: Fixed USE="id3tag" compilation. Closes: https://github.com/gentoo/gentoo/pull/6843 Closes: https://bugs.gentoo.org/636722 Package-Manager: Portage-2.3.24, Repoman-2.3.6 media-sound/audacity/audacity-2.2.1.ebuild | 10 ++- .../files/audacity-2.2.1-without-libid3tag.patch | 87 ++++++++++++++++++++++ 2 files changed, 96 insertions(+), 1 deletion(-) |