Bug 636266

Summary:	media-libs/sdl-sound-1.0.3-r1 : /.../physfsrwops.h:42:1: error: unknown type name __EXPORT__
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal	CC:	zeekec
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/11319
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	emerge-info.txt emerge-history.txt environment etc.portage.tbz2 logs.tbz2 media-libs:sdl-sound-1.0.3-r1:20171101-222659.log temp.tbz2 Patch to make SDL_sound compile with =dev-games/physfs-3.0.1

Description Toralf Förster gentoo-dev

2017-11-02 16:23:24 UTC

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/media-libs/sdl-sound-1.0.3-r1/work/SDL_sound-1.0.3/playsound -I.. -I/var/tmp/portage/media-libs/sdl-sound-1.0.3-r1/work/SDL_sound-1.0.3   -DSUPPORT_PHYSFS=1 -O2 -pipe -march=native -Wall -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -c -o playsound-playsound.o `test -f 'playsound.c' || echo '/var/tmp/portage/media-libs/sdl-sound-1.0.3-r1/work/SDL_sound-1.0.3/playsound/'`playsound.c
In file included from /var/tmp/portage/media-libs/sdl-sound-1.0.3-r1/work/SDL_sound-1.0.3/playsound/playsound.c:51:0:
/var/tmp/portage/media-libs/sdl-sound-1.0.3-r1/work/SDL_sound-1.0.3/playsound/physfsrwops.h:42:1: error: unknown type name ‘__EXPORT__’
 __EXPORT__ SDL_RWops *PHYSFSRWOPS_openRead(const char *fname);
 ^~~~~~~~~~
/var/tmp/portage/media-libs/sdl-sound-1.0.3-r1/work/SDL_sound-1.0.3/playsound/physfsrwops.h:42:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-desktop-plasma_libressl_20171027-191648

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.4.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python3.6 (fallback)
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby22 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.5.1 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

emerge -qpv media-libs/sdl-sound
[ebuild  N    ] media-libs/sdl-sound-1.0.3-r1  USE="flac mp3 mpeg physfs vorbis -mikmod -modplug -speex -static-libs" ABI_X86="(64) -32 (-x32)"

Comment 1 Toralf Förster gentoo-dev

2017-11-02 16:23:29 UTC

Created attachment 501706 [details]
emerge-info.txt

Comment 2 Toralf Förster gentoo-dev

2017-11-02 16:23:32 UTC

Created attachment 501708 [details]
emerge-history.txt

Comment 3 Toralf Förster gentoo-dev

2017-11-02 16:23:35 UTC

Created attachment 501710 [details]
environment

Comment 4 Toralf Förster gentoo-dev

2017-11-02 16:23:39 UTC

Created attachment 501712 [details]
etc.portage.tbz2

Comment 5 Toralf Förster gentoo-dev

2017-11-02 16:23:41 UTC

Created attachment 501714 [details]
logs.tbz2

Comment 6 Toralf Förster gentoo-dev

2017-11-02 16:23:44 UTC

Created attachment 501716 [details]
media-libs:sdl-sound-1.0.3-r1:20171101-222659.log

Comment 7 Toralf Förster gentoo-dev

2017-11-02 16:23:47 UTC

Created attachment 501718 [details]
temp.tbz2

Comment 8 François Thibault 2017-12-23 10:45:23 UTC

Created attachment 511534 [details, diff]
Patch to make SDL_sound compile with =dev-games/physfs-3.0.1

This makes sdl-sound-1.0.3-r1 compile again.

The only package that depends on this package on my system (=games-emulation/dosbox-0.74_p20160629-r1::gentoo) emerges fine after that.

Comment 9 ron widler 2018-01-04 22:10:36 UTC

Ran into the same problems, François Thibault's patch works for me, too.
everything compiling nicely again.

Comment 10 Conrad Kostecki gentoo-dev

2019-03-09 15:04:35 UTC

Thanks, patch works for me.
I've reworked the eBuild for EAPI=7 and will submit a PR including this patch.

Comment 11 Larry the Git Cow gentoo-dev

2019-03-09 21:59:42 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd01fdf7773b74566b1371632c3f9ff90927dcd3

commit dd01fdf7773b74566b1371632c3f9ff90927dcd3
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-03-09 15:02:52 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-03-09 21:59:31 +0000

    media-libs/sdl-sound: fix build with dev-games/physfs-3.0.1
    
    Also reworked whole eBuild and bumped to EAPI=7.
    Added also new build options, to support more formats.
    
    Closes: https://bugs.gentoo.org/636266
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/11319
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../files/sdl-sound-1.0.3-physfs-3.0.1.patch       | 38 ++++++++++
 media-libs/sdl-sound/metadata.xml                  | 17 +++--
 media-libs/sdl-sound/sdl-sound-1.0.3-r2.ebuild     | 84 ++++++++++++++++++++++
 3 files changed, 132 insertions(+), 7 deletions(-)