Bug 63525

Summary:	Patch to the get_delta.sh for the new deltup alternative by blackpengiun
Product:	Portage Development	Reporter:	Pkunk <dilipv>
Component:	Third-Party Tools	Assignee:	Portage Tools Team <tools-portage>
Status:	RESOLVED UPSTREAM
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Updated get_delta.sh script

Description Pkunk 2004-09-10 02:43:31 UTC

This is a patch for the very good Deltup alternative by blackpengiun @ http://linux01.gwdg.de/~nlissne/

Suppose the existing file which is to be upgrade is corrupt or incomplete , get_delta.sh will still try to download a dtu patch for it , and then fail after going through the download with the "original file is corrupt" message. I recently had download an 8 meg dtu and after downloading it told "original file is corrupt" and proceeded to download the new file.

I have implemented some local checks into the get_delta.sh script which check the digest files if availabe , and if not test the tarball for corruption and then if the file is corrupt , NOT download the dtu , but instead ask the user to delete the old file and retry.

Firstly , please update your /etc/make.conf with

FETCHCOMMAND="/usr/bin/getdelta_pkunk.sh \${URI} \${FILESDIR} \${PF}"

Then download the getdelta_pkunk.sh file attached below and place it in /usr/bin/getdelta_pkunk.sh . If you place it in any other folder then change the FETCHCOMMAND accordingly

Reproducible: Always
Steps to Reproduce:
1. Try to download an updated tarball , when corrupted/incomplete old version files exists in distfiles/
2.deltup will not check if the "best canidate" for update is already corrupt and download the DTU
3.deltup will then error out because the original file is corrupt after downloading the .dtu

Comment 1 Pkunk 2004-09-10 02:45:10 UTC

Created attachment 39292 [details]
Updated get_delta.sh script

Place this updated script in /usr/bin  and chmod 775 it

Comment 2 Nicolai Lissner 2004-09-11 19:34:15 UTC

Just close this bug - Pkunk's patch is for a tool not in portage.

I've released a new version of getdelta.sh incl. Pkunk's suggestion.

However this is not the right place to discuss problems or enhancements of tools not in the portage tree.

Pkunk, I cannot close it - but as the reporter you can do.

Comment 3 Marius Mauch (RETIRED) gentoo-dev

2004-10-06 02:47:29 UTC

Not out bug