Bug 635066

Summary:	make.defaults: remove USE=justify for hardened profiles
Product:	Gentoo Linux	Reporter:	Michael Orlitzky <mjo>
Component:	Profiles	Assignee:	The Gentoo Linux Hardened Team <hardened>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	0001-profiles-unset-default-USE-justify-in-hardened-profi.patch

Description Michael Orlitzky gentoo-dev

2017-10-22 12:49:43 UTC

The "justify" USE flag is used only by app-editors/nano, but it is enabled by default in two locations,

  * hardened/linux/amd64/make.defaults
  * features/hardened/amd64/make.defaults

Now that nano isn't even part of the @system set, is that necessary?

Comment 1 Michael Orlitzky gentoo-dev

2017-12-07 02:37:37 UTC

<Zorry> feel free to remove that one

I'll do it eventually if no one else beats me to it.

Comment 2 Michael Orlitzky gentoo-dev

2017-12-15 17:02:30 UTC

Created attachment 510190 [details, diff]
0001-profiles-unset-default-USE-justify-in-hardened-profi.patch

Proposed patch, will send to -dev and commit if no one claims that it will ruin his life.

Comment 3 Larry the Git Cow gentoo-dev

2017-12-20 01:06:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8b976076a9905d004819d375f669c4c2288243d

commit e8b976076a9905d004819d375f669c4c2288243d
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2017-12-15 16:44:49 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2017-12-20 01:05:12 +0000

    profiles: unset default USE=justify in hardened profiles.
    
    The "justify" USE flag is local to only app-editors/nano, but it was
    enabled by default in two hardened profiles,
    
      * hardened/linux/amd64/make.defaults
      * features/hardened/amd64/make.defaults
    
    The reasoning for that is lost to time, but probably dates back to
    when nano was part of the @system set, and we wanted the stages to be
    built with USE=justify set for nano (before per-package USE defaults).
    
    Closes: https://bugs.gentoo.org/635066

 profiles/features/hardened/amd64/make.defaults | 2 +-
 profiles/hardened/linux/amd64/make.defaults    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)