Summary: | Git hook: "Fixes:" in commit message triggers a warning | ||
---|---|---|---|
Product: | Gentoo Infrastructure | Reporter: | Ulrich Müller <ulm> |
Component: | Git | Assignee: | Gentoo Infrastructure <infra-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mgorny, whissi |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Ulrich Müller
2017-10-17 09:58:16 UTC
Should be fixed now. Please close when someone confirms. I just pushed https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80ca6a7673eb880effda57e878fe5cb4f8ad5018 and got > $ git push > Enumerating objects: 9, done. > Counting objects: 100% (9/9), done. > Delta compression using up to 4 threads > Compressing objects: 100% (5/5), done. > Writing objects: 100% (5/5), 1.01 KiB | 1.01 MiB/s, done. > Total 5 (delta 4), reused 0 (delta 0) > remote: WARNING: 'Fixes' tag should reference commit id, not: https://bugs.gentoo.org/701560 > remote: * Info: Using [Gentoo] (https://bugs.gentoo.org/xmlrpc.cgi) > remote: * Info: Modified the following fields in bug 701560 > remote: * Info: status : removed CONFIRMED > remote: * Info: status : added RESOLVED > remote: * Info: resolution : removed > remote: * Info: resolution : added FIXED > remote: To github.com:gentoo/gentoo.git > remote: 28cb4fcc47c..80ca6a7673e master -> master > To git+ssh://git.gentoo.org/repo/gentoo.git > 28cb4fcc47c3..80ca6a7673eb master -> master > Will try later with commit id. mgorny: Please permit URLs in the Fixes footer. They make it possible to cleanly link issues in external trackers, including GitHub. It's not semantically the same as "Closes:" which does permit a URL. Fixes states that the linked issue is considered closed AND fixed, not just closed. AFAICS this is fixed since some time. |