Summary: | net-analyzer/ntopng-3.0-r1 - src/AddressResolution.cpp:55:35: error: ISO C++ forbids comparison between pointer and integer [-fpermissive] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Fred Krogh <fkrogh> |
Component: | Current packages | Assignee: | Sławek Lis (RETIRED) <slis> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | silvio.gerli, zoltan |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | ~arch only | ||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 617524 | ||
Attachments: | Patch to incorrect pointer integer comparison. |
Description
Fred Krogh
2017-10-12 16:14:11 UTC
Created attachment 506904 [details, diff]
Patch to incorrect pointer integer comparison.
Compiler is correct, strchr() will return NULL if character (in this case '@') is not found. Code tries to truncate string if '@' is found (starting from '@' symbol). This patch fixes the code and makes ntopng compile.
Patch sent, thanks for your help Not sure if it should be a new bug but the patch was added as files/pointer-cmp.patch but the ebuild line is "${FILESDIR}"/${P}-pointer-cmp.patch". The mismatch in the name causes the build to fail. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47316be9937674510b62d56065bacc467660d31f commit 47316be9937674510b62d56065bacc467660d31f Author: Slawomir Lis <slis@gentoo.org> AuthorDate: 2018-01-22 20:55:44 +0000 Commit: Slawomir Lis <slis@gentoo.org> CommitDate: 2018-01-22 21:00:30 +0000 net-analyzer/ntopng: added sys-libs/binutils-libs dependency Closes: https://bugs.gentoo.org/634104 Package-Manager: Portage-2.3.20, Repoman-2.3.6 net-analyzer/ntopng/ntopng-3.0-r2.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) |