| Summary: | dev-embedded/gpsim-0.30.0 stabilisation (was: gcc >=7.x patches) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | CaptainBlood <luc_pierard_de_maujouy> | ||||||
| Component: | Stabilization | Assignee: | Embedded Gentoo Team <embedded> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | normal | Keywords: | CC-ARCHES | ||||||
| Priority: | Normal | Flags: | nattka:
sanity-check+
|
||||||
| Version: | unspecified | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=607172 | ||||||||
| Whiteboard: | |||||||||
| Package list: |
dev-embedded/gpsim-0.30.0
|
Runtime testing required: | --- | ||||||
| Attachments: |
|
||||||||
Created attachment 498382 [details, diff]
patch #2
Ran into this issue on dev-embedded/gpsim-0.29.0 (stable version at time of writing this comment) while updating my machine - gpsim-0.29.0 will always fail with gcc-7.3. Should gpsim-0.30.0 be stabilized?
I think the patch should be written as
if (list == NULL) {
instead of 0 (ugly) or false(bad programming style), as that's what eXdbm wrote it as and it returns a list, after all.
However, it looks like gpsim-0.30.0 has this issue fixed as:
if (!list) {
so we may simply need a version stabilization. gpsim-0.30.0 at least builds as-is without patches.
(Note that I've virtually stopped using PICs after discovering AVRs, so I'd be a poor tester for this software. Perhaps emerge --depclean gpsim would have been my easiest way out of updating this machine :-))
okay, we are a bit past maintainer timeout here I think. amd64 done x86 done all arches done |
Created attachment 498380 [details, diff] patch #1 builds fine now!