Summary: | www-client/firefox-52.4.0 fails to compile with ld: libxul.so: hidden symbol `_....` isn't defined | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | dE <de.techno> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED INVALID | ||
Severity: | normal | CC: | alex, doj, Ikonta, O01eg, ps, steven.cordwell, tharvik, toolchain |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Failed build log for Firefox. |
Description
dE
2017-10-06 17:27:08 UTC
Could you do an 'emerge --info' with the settings you actually used to build firefox? This one's got significantly more CFLAGS and is showing gold as your LD... This is a pgo build failure nothing to do with gcc-6.4, A simple patch is all that is needed that has not been included in gentoo. This is already landed in 57 branch and is actually a dupe of bug 617690, I am not interested in backporting the pgo fix for firefox-esr, the patch will apply cleanly and can be applied by the users. *** This bug has been marked as a duplicate of bug 617690 *** Oh, didn't notice the pgo flag. https://bugs.gentoo.org/show_bug.cgi?id=627140 Sorry. I went ahead and committed a new patchset that includes the fix. This will just make for less noise. Will need to re-address the patch. In tree has been reverted due to breakage it introduced. Please ping on this bug if you need compile or runtime testing. Hello, I had related bug triggered on gcc 4.9.4: In file included from /var/tmp/portage/www-client/firefox-52.4.0/work/firefox-52.4.0esr/ff/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:65:0: /var/tmp/portage/www-client/firefox-52.4.0/work/firefox-52.4.0esr/gfx/thebes/gfxFont.cpp:2625:29: error: 'mozilla::gfx::ShapedTextFlags' has not been declared gfx::ShapedTextFlags aFlags, ^ /var/tmp/portage/www-client/firefox-52.4.0/work/firefox-52.4.0esr/gfx/thebes/gfxFont.cpp:2626:24: error: 'RoundingFlags' has not been declared RoundingFlags aRounding, ^ /var/tmp/portage/www-client/firefox-52.4.0/work/firefox-52.4.0esr/gfx/thebes/gfxFont.cpp:2618:1: error: template-id 'GetShapedWord<>' for 'gfxShapedWord* gfxFont::GetShapedWord(gfxFont::DrawTarget*, const uint8_t*, uint32_t, uint32_t, gfxFont::Script, bool, int32_t, int, int, gfxTextPerfMetrics*)' does not match any template declaration gfxFont::GetShapedWord(DrawTarget *aDrawTarget, ^ Reverting this patch: https://hg.mozilla.org/mozilla-central/rev/97dae871389b solved the issue for firefox-52.4.0 & gcc 4.9.4 in my case. I also had the problem with gfx::ShapedTextFlags aFlags but resolved it by disabling system-* use-flags. *** Bug 634006 has been marked as a duplicate of this bug. *** Hello, getting the same errors (undefined reference to `gfxShapedWord* gfxFont::GetShapedWord and libxul.so: hidden symbol) with firefox-52.5.2 and gcc-6.4.0 with ld.gold. (In reply to Hadrien Lacour from comment #10) > Hello, getting the same errors (undefined reference to `gfxShapedWord* > gfxFont::GetShapedWord and libxul.so: hidden symbol) with firefox-52.5.2 and > gcc-6.4.0 with ld.gold. We are not gonna fix pgo support, we have drop'd it from firefox 58 and will leave it removed in next esr which will be 59. (In reply to Jory A. Pratt from comment #11) > We are not gonna fix pgo support, we have drop'd it from firefox 58 and will > leave it removed in next esr which will be 59. Sorry, looks like I didn't read the thread carefully enough. *** Bug 641478 has been marked as a duplicate of this bug. *** *** Bug 641856 has been marked as a duplicate of this bug. *** *** Bug 647104 has been marked as a duplicate of this bug. *** Please feel free to reopen and update any bug report that can be duplicated with current esr builds, 60.x. If you feel your feature needs to be re looked at in any of these bugs reopen and update, please attach patches when appropriate. Thank you Mozilla Team |