| Summary: | media-libs/suil-0.10.0 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andreas Sturmlechner <asturm> |
| Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | simon.vanderveldt+gentoo |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://drobilla.net/category/suil/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 631914 | ||
|
Description
Andreas Sturmlechner
2017-10-04 18:58:35 UTC
I'd like to create a PR to get this in, but I'm unsure about how to handle the gtk/qt/X combinations. There are checks for almost every combination (gtk2 + Qt4, gtk2 + Qt5, etc). These determine which libs get built and unfortunately they determine both the toolkit used by the application that includes suil as well as the toolkit that can be embedded with the application that includes suil. How should this be handled? I'm leaning towards a gtk2 and a gtk3 USE flags because that's what suil offers, but that seems to be against the GNOME/gtk+ policy Also I'm not sure how the GNOME/gtk policy ties into this https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies#GTK.2B_USE-flag_and_slots_usage :? Any ideas/suggestions? Wrt Qt4 my suggestion is: Don't bother with it at all and only provide Qt5. (In reply to Andreas Sturmlechner from comment #2) > Wrt Qt4 my suggestion is: Don't bother with it at all and only provide Qt5. OK, thanks! I'm mainly unsure about the gtk part though. Not sure if we should have USE gtk2 and gtk3 or just gtk and don't bother about the gtk3 part (or depend on both gtk2 and gtk3). What do you think? For reference this is what the wscript does based on available toolkits https://github.com/drobilla/suil/blob/master/wscript#L107 Based on the support currently provided by suil-0.8.4 you could just postpone that decision and really only provide gtk2 as-is. Maybe it will make more sense to think about gtk3 if a follow-up release comes up with full support, similar to what 0.10.0 has done with Qt5. (In reply to Andreas Sturmlechner from comment #4) > Based on the support currently provided by suil-0.8.4 you could just > postpone that decision and really only provide gtk2 as-is. Maybe it will > make more sense to think about gtk3 if a follow-up release comes up with > full support, similar to what 0.10.0 has done with Qt5. Good point, I've just create a PR that keeps it the same apart from removing some Qt5 comments/fixes that are no longer necessary. There's one unfortunate issue, one can explicitly disable qt4 and qt5, but no such option is available for gtk2/gtk3. It's either gtk enabled and gtk2/gtk3 get detected during configure or nothing. Should I add a patch to fix this? This issue has been fixed, see https://github.com/gentoo/gentoo/commit/34ca46993bf79eb4f1f1069d8f015509cfce4249. I just noticed that jalv 1.6.0 (the current release) segfaults when using Qt5 plugins within jalv.gtk. The fixes for this seem to be in current master. Should I create a new issue for that? Issue for jalv can be found here https://github.com/drobilla/jalv/issues/4 (In reply to Simon from comment #6) > Should I create a new issue for that? > Issue for jalv can be found here https://github.com/drobilla/jalv/issues/4 Yes please, that is stuff for a new bug. Maybe you can find out the exact fix for us to backport? media-libs/suil-0.10.0 added in git commit 34ca46993bf79eb4f1f1069d8f015509cfce4249 (In reply to Andreas Sturmlechner from comment #7) > (In reply to Simon from comment #6) > > Should I create a new issue for that? > > Issue for jalv can be found here https://github.com/drobilla/jalv/issues/4 > Yes please, that is stuff for a new bug. Maybe you can find out the exact > fix for us to backport? Done, see https://bugs.gentoo.org/634030 |