Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 632315

Summary: www-client/firefox "pgo" flag mangles compilation flags set by user.
Product: Gentoo Linux Reporter: R030t1
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED WONTFIX    
Severity: normal CC: tsmksubc
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description R030t1 2017-09-28 20:50:13 UTC
Hello,

I recently learned that certain eix flags were removed for setting custom flags in their compilation environment. It is likely Firefox does similar, so please remove the offending use flags from www-client/firefox as well.

Respectfully,
     R0b0t1
Comment 1 Jory A. Pratt gentoo-dev 2017-10-02 19:27:32 UTC
Please provide all relevant info to your bug report. I am not gonna sit here and guess what you are expecting.
Comment 2 R030t1 2017-11-15 15:47:39 UTC
My apologies for the delay.

The "pgo" option seems to enable "-O3." Modification of useflags outside of make.conf is against ebuild policy.

That the culprit is "pgo" is my best guess. All I know is that I saw "-O3" in Firefox build commands and I never set "-O3."
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2017-11-15 15:58:32 UTC
(In reply to R030t1 from comment #2)
> My apologies for the delay.
> 
> The "pgo" option seems to enable "-O3." Modification of useflags outside of
> make.conf is against ebuild policy.
> 
> That the culprit is "pgo" is my best guess. All I know is that I saw "-O3"
> in Firefox build commands and I never set "-O3."


The mozilla build system needs to maintain control of optimization, otherwise things can go awry.  To compensate for those that want to go against mozilla's build system settings we have a 'custom-optimization' flag that allows optimization in CFLAGS to be honoured.  We won't be changing this nor making custom-optimization default-enabled until such time as it's no longer needed by upstream.

Closing as WONTFIX because when mozilla -does- always build reliably with whatever optimization is specified in CFLAGS, we will drop the use flag and honour CFLAGS on our own.