Bug 632200 – [kde overlay] kde-apps/gwenview-9999 now requires sci-libs/cfitsio

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Duncan 2017-09-27 22:24:14 UTC]

Gwenview upstream says CFitsio now REQUIRED

See upstream commit b49569c97: Add FITS format support

The main cmake.txt chunk of the diff:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index e9f3ca9eb..8dd8d5e1a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -98,6 +98,9 @@ set_package_properties(PNG PROPERTIES URL "http://www.libpng.org" DESCRIPTION "P
 find_package(Exiv2)
 set_package_properties(Exiv2 PROPERTIES URL "http://www.exiv2.org" DESCRIPTION "image metadata support" TYPE REQUIRED)

+find_package(CFitsio)
+set_package_properties(CFitsio PROPERTIES URL "http://heasarc.gsfc.nasa.gov/fitsio/fitsio.html" DESCRIPTION "FITS format support" TYPE REQUIRED)
+
 find_package(KF5Kipi)
 if (KF5Kipi_FOUND)
    set(KIPI_FOUND true)

[Comment 1 Duncan 2017-09-27 22:33:40 UTC]

Indeed, after merging sci-libs/cfitsio, gwenview builds again.  Unfortunately that's a rather obscure REQUIRED for a desktop image viewer, but at least it's a reasonably light dep, as those things go. =:^)

[Comment 2 Andreas Sturmlechner 2017-09-28 11:52:56 UTC]

Not sure that's intended to be really required though.

[Comment 3 Duncan 2017-09-28 20:04:05 UTC]

(In reply to Andreas Sturmlechner from comment #2)
> Not sure that's intended to be really required though.

Indeed, there's review discussion on it being optional, but the final commit still had it as required, so unless that's changed before release and thus becomes just a blip in the live-git history...

(Meanwhile, I appreciate depclean's behavior when I did my routine --depclean --ask run after update.  Despite my not adding cfitsio to a set in world-sets and it not being a dep in the ebuild yet, because until this is sorted it's a temporary merge, depclean correctly detected the binary dependency and automatically added cfitsio to its dependency graph.  Years ago it wouldn't have been that smart, and I appreciate the "new" behavior, tho I guess it's not /that/ new any more, but I still appreciate it. It's nice to have tools you can depend on. =:^)

[Comment 4 Andreas Sturmlechner 2017-10-22 15:02:10 UTC]

Fix pushed in git commit ae4172895d1de98be7727abff3171cd7d226498f and pending upstream.