Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 631892

Summary: net-misc/x2goclient - drop qt4 support
Product: Gentoo Linux Reporter: Michael Palimaka (kensington) <kensington>
Component: Current packagesAssignee: Bernard Cafarelli <voyageur>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 644852    
Bug Blocks: 631788    
Attachments: Build log.

Description Michael Palimaka (kensington) gentoo-dev 2017-09-24 06:45:31 UTC
It looks like net-misc/x2goclient supports both qt4 and qt5. Since qt4 is dead, please drop it and just use qt5 instead.
Comment 1 Bernard Cafarelli gentoo-dev 2017-09-25 13:44:07 UTC
OK I ended modifying most parts of the ebuild, so I only dropped qt4 support in new revision x2goclient-4.1.0.1-r1.

Let's keep this bug open until this one is stabilized (once I am sure I did not break anything)
Comment 2 Bernd Feige 2017-09-26 08:26:37 UTC
(In reply to Bernard Cafarelli from comment #1)
> OK I ended modifying most parts of the ebuild, so I only dropped qt4 support
> in new revision x2goclient-4.1.0.1-r1.
> 
> Let's keep this bug open until this one is stabilized (once I am sure I did
> not break anything)

So I should probably report here that x2goclient-4.1.0.1-r1 broke for me (4.1.0.1 itself was fine) ;-)

/usr/lib64/qt5/bin/rcc -name resources res/resources.qrc -o qrc_resources.cpp
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_es.qm'
make: *** [Makefile:851: qrc_resources.cpp] Error 1
Comment 3 Bernard Cafarelli gentoo-dev 2017-09-26 09:01:24 UTC
(In reply to Bernd Feige from comment #2)
> /usr/lib64/qt5/bin/rcc -name resources res/resources.qrc -o qrc_resources.cpp
> RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_es.qm'
> make: *** [Makefile:851: qrc_resources.cpp] Error 1

Hmm thees RCC errors should only appear in configure step (and lrelease in compile step should generate the files), this has not changed betwen both revisions:

>>> Configuring source in /var/tmp/portage/net-misc/x2goclient-4.1.0.1-r1/work/x2goclient-4.1.0.1 ...
[...]
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_da.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_de.qm'
[...]
>>> Compiling source in /var/tmp/portage/net-misc/x2goclient-4.1.0.1-r1/work/x2goclient-4.1.0.1 ...
make -j8 
/usr/lib64/qt5/bin/lrelease res/i18n/x2goclient_de.ts
[...]
Updating 'res/i18n/x2goclient_de.qm'...
    Generated 683 translation(s) (683 finished and 0 unfinished)
[...]
/usr/lib64/qt5/bin/rcc -name resources res/resources.qrc -o qrc_resources.cpp
[no error here]

Did you have USE=qt5 on -r0 build? Which qt version? Let's check full emerge --config and build log, I *think* this is not related to the revbump in itself
Comment 4 Bernd Feige 2017-09-26 09:22:37 UTC
Created attachment 496434 [details]
Build log.

Attached my build log.

Yes, USE=qt5 is set.

Emerging net-misc/x2goclient-4.1.0.1 works nicely. As you say, it only has non-fatal errors during config like:
RCC: Error in '../x2goclient-4.1.0.1/res/resources.qrc': Cannot find file 'i18n/x2goclient_da.qm'

Re emerge --config: Did you mean emerge --info? Here it is!
 

Portage 2.3.10 (python 3.6.1-final-0, default/linux/amd64/13.0, gcc-6.4.0, glibc-2.25-r5, 4.13.3-gentoo x86_64)
=================================================================
System uname: Linux-4.13.3-gentoo-x86_64-Intel-R-_Core-TM-_i7-4790_CPU_@_3.60GHz-with-gentoo-2.4.1
KiB Mem:    32913408 total,  18785456 free
KiB Swap:   33554428 total,  33123580 free
Timestamp of repository gentoo: Tue, 26 Sep 2017 00:45:01 +0000
Head commit of repository gentoo: 99650c16a56f55d423f086befae53446919c2f47
sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p1.0) 2.29.1
distcc 3.2rc1 x86_64-pc-linux-gnu [enabled]
ccache version 3.3.4 [enabled]
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r3::bfown
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.14::gentoo, 3.6.1-r1::gentoo
dev-util/ccache:          3.3.4-r1::gentoo
dev-util/cmake:           3.9.3::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.31.2::gentoo
sys-apps/sandbox:         2.10-r4::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.15.1-r1::gentoo
sys-devel/binutils:       2.29.1::gentoo
sys-devel/gcc:            6.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r4::gentoo
sys-devel/make:           4.2.1-r1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r5::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.de.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 

science
    location: /gentoo/local/layman/science
    masters: gentoo
    priority: 50

bfown
    location: /gentoo/overlay
    masters: gentoo science
    priority: 100

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/chromium/policies/managed/chrome-gnome-shell.json /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/opt/chrome/policies/managed/chrome-gnome-shell.json /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/gentoo/distfiles/"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg ccache config-protect-if-modified distcc distcc-pump distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://de-mirror.org/linux/distributions/gentoo/ http://distfiles.gentoo.org"
LANG="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j36 -l4"
PKGDIR="/gentoo/packages/x64"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="R X a52 aac acl acpi afs alsa amd64 audit bacula-clientonly berkdb blas bluetooth btrfs bzip2 cairo caps cddb cdparanoia cdr cli clutter colord colorio cpudetection cracklib crypt cscope cups cxx dbus dga djvu dri dv dvd dvdr dvdread dvi eds egl enblend encode evo exif ext4 extrafilters faac ffmpeg fftw flac fluidsynth fontconfig fortran fuse g3dvl gdbm gegl gif gimp gles gmp gnome gnome-keyring gnutls graphics graphviz gs gstreamer gtk gtk3 hddtemp hdri iconv icu id3tag imagemagick ipv6 ipython jack java jbig jingle jpeg jpeg2k kerberos kpathsea ladspa lame lapack latex lcms ldap lensfun libnotify lm_sensors lv2 lyx lzma lzo mad matplotlib matroska md5sum midi mjpeg mng modules mp2 mp3 mpeg mtp multilib musepack nautilus ncurses nfs nls nptl numpy office ofx ogg openal opencl opencv openexr opengl openmp opus otr pam pcre pda pdf pep8 playlist plotutils plugins png pnm policykit postgres postscript pulseaudio pylint python qt3support quicktime radio rar raw readline real rtc rtmp sbsms scanner science scipy sdl seccomp sendto session sift sndfile sound soundtouch speex spell sqlite ssl svg systemd t1lib taglib tcpd telepathy theora threads tiff tivo tracker truetype twolame udev udisks umfpack unicode upnp v4l vaapi vamp vdpau vim-syntax vorbis vpx wayland webkit webp win32codecs wmf x264 xattr xcomposite xetex xinerama xml xmp xmpp xps xv xvid xvmc zlib zoran" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="canon ptp2 samsung" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 sse4_1 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="de en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer nlpsolver pdfimport" LINGUAS="de en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" QEMU_SOFTMMU_TARGETS="x86_64 i386" QEMU_USER_TARGETS="x86_64 i386" RUBY_TARGETS="ruby24" SANE_BACKENDS="hp5590 genesys" USERLAND="GNU" VIDEO_CARDS="radeon radeonsi amdgpu" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 5 Bernd Feige 2017-09-26 09:32:35 UTC
(In reply to Bernd Feige from comment #4)

> Yes, USE=qt5 is set.

Oops, I'm wrong - it's set by me but somehow masked:

# USE=qt5 emerge -1 -pv x2goclient

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild     U  ] net-misc/x2goclient-4.1.0.1-r1::gentoo [4.1.0.1::gentoo] USE="ldap (-nsplugin%) (-qt5%*)" 0 KiB

Don't know what's going on there; with 4.1.0.1 I have:

# emerge -1 -pv =x2goclient-4.1.0.1

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] net-misc/x2goclient-4.1.0.1::gentoo  USE="ldap qt5 -nsplugin" 0 KiB
Comment 6 Michael Palimaka (kensington) gentoo-dev 2017-09-26 12:28:13 UTC
Could you try with FEATURES="-ccache -distcc -distcc-pump" please?
Comment 7 Bernd Feige 2017-09-26 12:58:57 UTC
(In reply to Michael Palimaka (kensington) from comment #6)
> Could you try with FEATURES="-ccache -distcc -distcc-pump" please?

Same result!
Comment 8 Bernd Feige 2017-09-26 15:02:12 UTC
Sorry, the complaint about qt5 is of course nonsense, the new ebuild simply doesn't have qt5 and nsplugin IUSE any more. I think I misunderstood Bernard's question about +qt5 in -r0, since we don't have a -r0 but a version without release modifier. So yes, that version was built and worked with +qt5.

I now looked more closely and found that the generation of ".qm" files via /usr/lib64/qt5/bin/lrelease seems to be flaky with my make parallelism:
MAKEOPTS="-j36 -l4"

Even with only "-j36" I didn't see it but only when also using "-l"...
Maybe a bug in sys-devel/make-4.2.1-r1 then?
Comment 9 Joseph 2018-01-03 05:10:21 UTC
I'm getting similar errors, doesn't matter which version I'm trying to compile
4.1.0.0-r1
4.1.0.1
4.1.0.1-r1
4.1.1.0

>>> Failed to emerge net-misc/x2goclient-4.1.0.1-r1, Log file:
>>>  '/var/log/portage/net-misc:x2goclient-4.1.0.1-r1:20180103-050959.log'
>>> Jobs: 0 of 1 complete, 1 failed                 Load avg: 0.18, 0.07, 0.09
 * Package:    net-misc/x2goclient-4.1.0.1-r1
 * Repository: gentoo
 * Maintainer: voyageur@gentoo.org
 * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux ldap userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
>>> cfg-update-1.8.2-r1: Checksum index is up-to-date ...
 * Running qmake ...
Info: creating stash file /var/tmp/portage/net-misc/x2goclient-4.1.0.1-r1/work/x2goclient-4.1.0.1/.qmake.stash
Project MESSAGE: if you want to build x2goplugin you should export X2GO_CLIENT_TARGET=plugin
Project MESSAGE: building x2goclient with ldap and cups
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_da.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_de.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_es.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_et.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_fi.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_fr.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_nb_no.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_nl.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_pt.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_ru.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_sv.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_tr.qm'
RCC: Error in 'res/resources.qrc': Cannot find file 'i18n/x2goclient_zh_tw.qm'
 [ ok ]
/usr/lib64/qt5/bin/lrelease res/i18n/x2goclient_de.ts
make: /usr/lib64/qt5/bin/lrelease: Command not found
make: *** [Makefile:537: x2goclient_de.qm] Error 127
 * ERROR: net-misc/x2goclient-4.1.0.1-r1::gentoo failed (compile phase):
 *   emake failed
Comment 10 Michael Palimaka (kensington) gentoo-dev 2018-01-03 08:55:03 UTC
(In reply to Joseph from comment #9)
> make: /usr/lib64/qt5/bin/lrelease: Command not found
> make: *** [Makefile:537: x2goclient_de.qm] Error 127
>  * ERROR: net-misc/x2goclient-4.1.0.1-r1::gentoo failed (compile phase):
>  *   emake failed

This one is a missing build-only dependency on dev-qt/linguist-tools:5.
Comment 11 Bernard Cafarelli gentoo-dev 2018-01-05 11:07:39 UTC
Thanks, added that dep to 4.1.1.0
 
As some time has passed, I think we can transform this into 4.1.1.0 stabling bug?
In that case we can open a new bug for Bernd Feige's MAKEOPTS="-lX" bug (there is a workaround)
Comment 12 Andreas Sturmlechner gentoo-dev 2018-01-16 16:46:36 UTC
Sure, go ahead and make this bug depend on the stabilisation bug.
Comment 13 Bernard Cafarelli gentoo-dev 2018-02-22 10:10:13 UTC
qt4 versions dropped from tree, all good here