Bug 63145 – vim.eclass should support Gnome 2 interface

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Ed Catmur 2004-09-07 10:17:28 UTC]

From http://www.vim.org/htmldoc/gui_x11.html#gui-gnome-session:

> 6. GNOME version				*gui-gnome* *Gnome* *GNOME*
>
> The GNOME GUI works just like the GTK+ version.  See |GTK+| above for how it
> works.  It looks a bit different though, and implements one important feature
> that's not available in the plain GTK+ GUI:  Interaction with the session
> manager. |gui-gnome-session|
> 
> These are the different looks:
> - Uses GNOME dialogs (GNOME 1 only).  The GNOME 2 GUI uses the same nice
>   dialogs as the GTK+ 2 version.

Currently the Gnome-related interfaces vim.eclass supports (with --enable-gui=) are gtk, gnome and gtk2. There is also in configure.in a gnome2 interface. This is useful because it has session support (and the Gnome toolbar). Otherwise it is largely identical to the gtk2 interface.

I suggest compiling in Gnome 2 support if the gnome and gtk2 USE flags are set:

--- vim.eclass  2004/09/07 16:47:58     1.1
+++ vim.eclass  2004/09/07 16:52:17
@@ -227,7 +227,9 @@ src_compile() {
                        myconf="${myconf} --enable-gui=no `use_with vim-with-x x`"
                elif [ ${PN} = gvim ] ; then
                        myconf="${myconf} --with-vim-name=gvim --with-x"
-                       if use gtk && use gtk2; then
+                       if use gnome && use gtk2; then
+                               myconf="${myconf} --enable-gui=gnome2 --enable-gtk2-check --enable-gnome-check"
+                       elif use gtk && use gtk2; then
                                myconf="${myconf} --enable-gui=gtk2 --enable-gtk2-check"
                        elif use gnome; then
                                myconf="${myconf} --enable-gui=gnome"

[Comment 1 Ciaran McCreesh 2004-09-07 16:36:26 UTC]

Happen to know exactly what gnome packages will be required at compile and runtime? Still waiting for gnome to compile here...

[Comment 2 Ed Catmur 2004-09-07 17:53:45 UTC]

It's a little complicated. I'm looking at configure.in and it seems that --enable-gui=gnome2 will just set SKIP_GNOME="", same as the Gnome 1 interface. However then inside the GNOME_INIT_HOOK function it behaves differently depending on the version of gtk2 available.

I believe that all it wants is >=libgnomeui-2.0 (line 1353).

Thus the gvim ebuild can be altered:
--- app-editors/gvim/gvim-6.3.ebuild    2004/09/08 00:51:13     1.1
+++ app-editors/gvim/gvim-6.3.ebuild    2004/09/08 00:52:11
@@ -24,7 +24,11 @@ DEPEND="${DEPEND}
        ~app-editors/vim-core-${PV}
        virtual/x11
        gtk? (
-               gtk2? ( >=x11-libs/gtk+-2.2 virtual/xft )
+               gtk2? (
+                       gnome? ( >=gnome-base/libgnomeui-2.0 )
+                       >=x11-libs/gtk+-2.2
+                       virtual/xft
+               )
                !gtk2? (
                        gnome? ( gnome-base/gnome-libs )
                        !gnome? ( =x11-libs/gtk+-1.2* )

gtk 2.2 and xft are of course still needed; the gnome2 version is very similar to the gtk2 version.

[Comment 3 Ciaran McCreesh 2004-09-07 18:12:30 UTC]

I'll include this in the next vim/vim-core/gvim revbump, thanks.

[Comment 4 Ciaran McCreesh 2004-09-10 16:30:33 UTC]

Included in gvim-6.3-r2.