Bug 631322 – sys-auth/elogind: New update series with important new features

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sven Eden 2017-09-18 13:19:44 UTC]

Hi everybody,

I have published and tested a new series of releases for elogind.

Here is a rundown of the most important updates:


* The command line argument -D/--daemon has been added. When used, elogind will double fork into background.
* elogind will write its real pid into /run/elogind.pid, and will delete that file on exit.
* The dbus service file org.freedesktop.login1.service has been updated to start elogind in daemon mode on any request if it isn't already running.
* pam_elogind will no longer quit and do nothing if elogind is not running when called by a user login.
* elogind now catches SIGINT, SIGQUIT and SIGTERM so it will cleanup and quit nicely if killed.
* When started while another instance of elogind is already running, elogind will no longer error out, but quit with exit code 0.
* A bug was fixed, introduced with the v231 series, that caused elogind to use the default sleep config instead what was configured in logind.conf.
* Following systemd upstream, elogind now installs into <rootprefix>/<libdir>/elogind

This has the following consequences for the gentoo integration:

* The init script got a bit simpler, and is now optional.
* I have extended the ebuilds pkg_postinst() message to address that adding elogind to the boot runlevel is now optional. (Gives greater control, though)
* start-stop-daemon no longer has to find out eloginds PID
* if elogind is killed or anything like that, dbus will make sure it is restarted when needed.

I will attach diffs to the current ebuilds and files, and post the ebuilds for the new versions.

Until merged, the ebuilds can be tested from my overlay (seden@layman)

Cheers

Sven

Note: This bug supersedes bug #626416

[Comment 1 Sven Eden 2017-09-18 13:23:02 UTC]

Sorry Andreas, I didn't realize the later bugs where assigned to you. I just wanted to assign it to freedesktop-bugs, but luckily checked the superseded bug first.

[Comment 2 Sven Eden 2017-09-18 13:29:33 UTC]

Created attachment 495228 [details, diff]
Update elogind-229.6.ebuild to elogind-229.8.ebuild

Latest stable release of the 229 series.

[Comment 3 Sven Eden 2017-09-18 13:30:26 UTC]

Created attachment 495230 [details, diff]
Update elogind-231.4.ebuild to elogind-231.6.ebuild

Latest release of the v231 series

[Comment 4 Sven Eden 2017-09-18 13:31:10 UTC]

Created attachment 495232 [details, diff]
Update elogind-232.3.ebuild to elogind-232.5.ebuild

Latest release of the v232 series

[Comment 5 Sven Eden 2017-09-18 13:31:57 UTC]

Created attachment 495234 [details]
elogind-233.6.ebuild

Latest release of the v233 series

[Comment 6 Sven Eden 2017-09-18 13:34:36 UTC]

Created attachment 495248 [details]
elogind-234.3.ebuild

Latest release of the v233 series

Just a note:

sys-apps/systemd only has v233 and v234 (keyworded) in the tree. So I think it would be enough to limit sys-auth/elogind to these two versions, too.

I will bring out releases for every (modern) systemd-stable branch they maintain, which includes v229, v231 and v232, but that doesn't mean we have to keep an ebuild for each, does it?

[Comment 7 Sven Eden 2017-09-18 13:36:50 UTC]

Created attachment 495250 [details, diff]
Update elogind.conf

The new variant is a conf.in file which get's its library path substituted by $(get_libdir)
Further the PID file path is now fixed on /run/elogind.pid, following upstream.

[Comment 8 Sven Eden 2017-09-18 13:38:09 UTC]

Created attachment 495252 [details, diff]
Update elogind.init

Although adding it to the boot runlevel is now optional, the init script has a simpler start-stop-daemon command now, since elogind can double fork into daemon mode by itself, now.

[Comment 9 Larry the Git Cow 2017-09-24 09:48:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c2421f4ab4bf7a439a0dc0bb5c9e58c1db480f6

commit 6c2421f4ab4bf7a439a0dc0bb5c9e58c1db480f6
Author:     Sven Eden <[e-mail]>
AuthorDate: 2017-09-24 09:47:23 +0000
Commit:     Michael Palimaka <[e-mail]>
CommitDate: 2017-09-24 09:48:01 +0000

    sys-auth/elogind: version bump all branches
    
    Closes: https://bugs.gentoo.org/631322
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 sys-auth/elogind/Manifest              |   5 ++
 sys-auth/elogind/elogind-229.8.ebuild  | 105 +++++++++++++++++++++++++++++++++
 sys-auth/elogind/elogind-231.6.ebuild  | 105 +++++++++++++++++++++++++++++++++
 sys-auth/elogind/elogind-232.5.ebuild  | 105 +++++++++++++++++++++++++++++++++
 sys-auth/elogind/elogind-233.6.ebuild  | 105 +++++++++++++++++++++++++++++++++
 sys-auth/elogind/elogind-234.3.ebuild  | 105 +++++++++++++++++++++++++++++++++
 sys-auth/elogind/files/elogind.conf.in |   7 +++
 sys-auth/elogind/files/elogind.init    |   6 +-
 8 files changed, 540 insertions(+), 3 deletions(-)

[Comment 10 Michael Palimaka (kensington) 2017-09-24 09:52:25 UTC]

Thanks Sven, I've bumped everything you've indicated.

(In reply to Sven Eden from comment #6)
> sys-apps/systemd only has v233 and v234 (keyworded) in the tree. So I think
> it would be enough to limit sys-auth/elogind to these two versions, too.
> 
> I will bring out releases for every (modern) systemd-stable branch they
> maintain, which includes v229, v231 and v232, but that doesn't mean we have
> to keep an ebuild for each, does it?

In most cases we probably only need to bump the ebuild for the latest and greatest version. That said, I think the person who knows best which versions we should carry is you so I suspect we'll keep bumping at your suggestion. :-)