Bug 629946 – app-emulation/libguestfs-1.36.5 fails tests: fatal: Not a git repository

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Kent Fredric (IRC: kent\n) (RETIRED) 2017-09-05 09:47:35 UTC]

Created attachment 492416 [details]
build.log.xz

>>> Test phase: app-emulation/libguestfs-1.36.5
 * Test::Harness Jobs=3
make -j3 test TEST_VERBOSE=0
fatal: Not a git repository (or any of the parent directories): .git
make: *** No rule to make target 'test'.  Stop.
 * ERROR: app-emulation/libguestfs-1.36.5::gentoo failed (test phase):
 *   emake failed


Inspection says:

strace -f -e trace=execve make test                            
execve("/usr/bin/make", ["make", "test"], [/* 51 vars */]) = 0              
strace: Process 809624 attached                     
[pid 809624] execve("/bin/sh", ["/bin/sh", "-c", "actual=$(git submodule status | "...], [/* 51 vars */]) = 0        

That line of code comes from cfg.mk

Which is used in the GNUmakefile

[Comment 1 Richard Jones 2017-09-05 13:12:28 UTC]

Do you happen to know what runs ‘make -j3 test TEST_VERBOSE=0’?

The normal way to run the full test suite is ‘make check’
(there are other testing methods, see:
http://libguestfs.org/guestfs-hacking.1.html#testing-your-changes )

[Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) 2017-09-05 15:25:21 UTC]

(In reply to Richard Jones from comment #1)
> Do you happen to know what runs ‘make -j3 test TEST_VERBOSE=0’?
> 
> The normal way to run the full test suite is ‘make check’
> (there are other testing methods, see:
> http://libguestfs.org/guestfs-hacking.1.html#testing-your-changes )

Given the word "Test::Harness" is used here, I'm guessing you're inheriting perl-module.eclass, which provides a default src_test 

If you want a different test routine to run, you'll have to avoid that somehow.

[Comment 3 Kent Fredric (IRC: kent\n) (RETIRED) 2017-09-05 15:28:56 UTC]

Actually, looking at the ebuild I don't see any obvious places where you'd want any of the special behaviour perl-module.eclass provides.

Maybe you just want perl-functions.eclass instead?

[Comment 4 Larry the Git Cow 2018-02-07 22:39:12 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5fdb7d569488c4f4a33a6d1cae714d45b5a4f56

commit d5fdb7d569488c4f4a33a6d1cae714d45b5a4f56
Author:     Gilles Dartiguelongue <[e-mail]>
AuthorDate: 2018-02-07 22:34:53 +0000
Commit:     Gilles Dartiguelongue <[e-mail]>
CommitDate: 2018-02-07 22:38:48 +0000

    app-emulation/libguestfs: version bump 1.36.5 → 1.36.13
    
        * Now compatible with >=glibc-2.26, bug #638180.
        * Make sure USE=introspection explicitely passes configure switch as we
          might split glib/gobject from introspection at some point.
        * Switch to perl-functions eclass as advised in bug #629946.
        * Restore USE=ocaml as I could not bug #629490 from provided info.
        * Fix pkg_postinst feature check on USE=gtk.
        * Fix build with FEATURES=test by disabling -Werror always. It makes no
          sense to enable this flag for a release, bug #640494.
        * Add myself to maintainers.
    
        Closes: https://bugs.gentoo.org/629690
        Closes: https://bugs.gentoo.org/629946
        Closes: https://bugs.gentoo.org/638180
        Closes: https://bugs.gentoo.org/640494
    
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 app-emulation/libguestfs/Manifest                  |   1 +
 app-emulation/libguestfs/libguestfs-1.36.13.ebuild | 173 +++++++++++++++++++++
 app-emulation/libguestfs/metadata.xml              |   4 +
 3 files changed, 178 insertions(+)