Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 629842

Summary: media-video/ogmrip (with app-text/enchant-2.1.0): ogmrip-spell-dialog.c:318: undefined reference to `enchant_dict_add_to_personal'
Product: Gentoo Linux Reporter: Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c>
Component: Current packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED OBSOLETE    
Severity: normal CC: treecleaner
Priority: Normal Keywords: PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 629838    
Attachments: build.log
Enchant-2 patch from Arch

Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-09-03 22:04:30 UTC
Created attachment 492218 [details]
build.log

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/
include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libp
ng16 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -I/usr/i
nclude/harfbuzz -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/enchant -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I../libogmdvd -I../libogmdvd-gtk -I../libogmjob -I../libogmrip -I../libogmrip -I../libogmrip-gtk -DOGMRIP_DATA_DIR=\""/usr/share"\"  -I/usr/local/include -I.. -Wall  -march=native -mtune=native -O2 -pipe -g -I/usr/local/include -I.. -Wall -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -c ogmrip-spell-dialog.c
ogmrip-spell-dialog.c: In function ‘ogmrip_spell_dialog_dispose’:
ogmrip-spell-dialog.c:252:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if (dialog->priv->dict);
     ^~
ogmrip-spell-dialog.c:253:7: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
       enchant_broker_free_dict (dialog->priv->broker, dialog->priv->dict);
       ^~~~~~~~~~~~~~~~~~~~~~~~
ogmrip-spell-dialog.c: In function ‘ogmrip_spell_dialog_check_word’:
ogmrip-spell-dialog.c:318:9: warning: implicit declaration of function ‘enchant_dict_add_to_personal’ [-Wimplicit-function-declaration]
         enchant_dict_add_to_personal (dialog->priv->dict, word, len);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ogmrip-spell-dialog.c:325:7: warning: implicit declaration of function ‘enchant_dict_free_suggestions’ [-Wimplicit-function-declaration]
       enchant_dict_free_suggestions (dialog->priv->dict, suggs);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

-------8<-------------8<-------------------8<------------------

libtool: link: x86_64-pc-linux-gnu-gcc -march=native -mtune=native -O2 -pipe -g -I/usr/local/include -I.. -Wall -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -Wl,--export-dynamic -o .libs/ogmrip ogmrip-crop-dialog.o ogmrip-gconf.o ogmrip-main.o ogmrip-marshal.o ogmrip-options-dialog.o ogmrip-pref-dialog.o ogmrip-profile-editor.o ogmrip-profiles.o ogmrip-profiles-dialog.o ogmrip-progress-dialog.o ogmrip-queue-dialog.o ogmrip-spell-dialog.o ogmrip-update-dialog.o ogmrip-audio-options.o ogmrip-subp-options.o -Wl,--export-dynamic -pthread  -Wl,--as-needed -L/usr/local/lib -L/usr/pkg/lib ../libogmdvd/.libs/libogmdvd.so ../libogmdvd-gtk/.libs/libogmdvd-gtk.so ../libogmjob/.libs/libogmjob.so ../libogmrip/.libs/libogmrip.so ../libogmrip-gtk/.libs/libogmrip-gtk.so /var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/libogmdvd-gtk/.libs/libogmdvd-gtk.so /var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/libogmrip/.libs/libogmrip.so /var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/libogmdvd/.libs/libogmdvd.so /var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/libogmjob/.libs/libogmjob.so -lgmodule-2.0 -lenca -lm -lglade-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lfontconfig -lfreetype -lxml2 -lgconf-2 -lenchant -ldbus-glib-1 -ldbus-1 -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -ldvdread -pthread
ogmrip-spell-dialog.o: In function `ogmrip_spell_dialog_check_word':
/var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/src/ogmrip-spell-dialog.c:325: undefined reference to `enchant_dict_free_suggestions'
/var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/src/ogmrip-spell-dialog.c:318: undefined reference to `enchant_dict_add_to_personal'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:451: ogmrip] Error 1
make[3]: Leaving directory '/var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/src'
make[2]: *** [Makefile:369: all] Error 2
make[2]: Leaving directory '/var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1/src'
make[1]: *** [Makefile:422: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-video/ogmrip-1.0.1/work/ogmrip-1.0.1'
make: *** [Makefile:353: all] Error 2
Comment 1 Dennis Lamm gentoo-dev 2019-02-13 20:10:30 UTC
Created attachment 565204 [details, diff]
Enchant-2 patch from Arch

Could you please test if the build succeeds with the attached patch?
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-04-25 13:45:44 UTC
Yes, with the attached patch, ogmrip compiles fine with both, old and new enchant.
Comment 3 Mart Raudsepp gentoo-dev 2020-02-02 19:56:21 UTC
the patch is not sufficient to switch over to enchant-2, which is now a different parallel-installable package with its own enchant-2.pc pkg-config file. I've locked the enchant dep to enchant:0, but this bug is still relevant for migrating everything over to enchant:2 - just now they can co-exist and we don't need to do migration all at once.
Comment 4 Andreas Sturmlechner gentoo-dev 2021-03-15 17:13:37 UTC
Debian seem to apply the same patch.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-19 13:52:51 UTC
Package removed.