Bug 629578

Summary:	media-libs/lensfun-0.3.2 ebuild passes wrong/obsolete options to cmake
Product:	Gentoo Linux	Reporter:	Alexander Miller <alex.miller>
Component:	Current packages	Assignee:	Gentoo Graphics Project <graphics+disabled>
Status:	RESOLVED FIXED
Severity:	normal	CC:	asturm, jstein
Priority:	Normal	Keywords:	EBUILD
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	lensfun-0.3.2-r1.ebuild

Description Alexander Miller 2017-09-02 01:06:49 UTC

Created attachment 491354 [details]
lensfun-0.3.2-r1.ebuild

The BUILD_AUXFUN option no longer exists; it has been replaced with BUILD_LENSTOOL, but that's not exactly the same (library vs. executable). Version 0.3.1 is affected, too. See <https://sourceforge.net/p/lensfun/code/ci/d8ae3d962fbdc2598b1d16770d27415083eed47a/>. I'd suggest to change -DBUILD_AUXFUN=ON to -DBUILD_LENSTOOL=ON, but you may choose to drop it instead (together with the libpng dependency).

Install paths can now be configured with standard CMAKE_INSTALL_XXX variables <https://sourceforge.net/p/lensfun/code/ci/797b2061e74a31cb38d35a1e76987bb29b9d0b0c/>. This fixes the wrong man pages installation path of 0.3.1, but -DDOCDIR=... and -DLIBDIR=... are no longer recognized and should be replaced with -DCMAKE_INSTALL_DOCDIR and -DCMAKE_INSTALL_LIBDIR, resp. While the default value for libdir was correct for *my* setup, the html docs (USE=doc) ended up in the wrong location.

I also noticed cmake checks for glib-2.40, so the dependency should be updated, too.

I've attached an updated ebuild for your convenience; also bumped EAPI=6 while at it.

Comment 1 Andreas Sturmlechner gentoo-dev

2017-12-25 23:08:09 UTC

Thanks for your contribution! Would you interested to help maintain this as proxy-maintainer?

https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

Comment 2 Larry the Git Cow gentoo-dev

2017-12-25 23:14:18 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3b9000b9cf5b1d1bdee9f02999289692befd6b1

commit d3b9000b9cf5b1d1bdee9f02999289692befd6b1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-12-25 23:09:01 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-12-25 23:13:39 +0000

    media-libs/lensfun: Fix cmake flags, bump to EAPI 6
    
    Thanks-to: Alexander Miller <alex.miller@gmx.de>
    Closes: https://bugs.gentoo.org/629578
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 media-libs/lensfun/lensfun-0.3.2-r1.ebuild | 47 ++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)