Bug 629108

Summary:	app-accessibility/caribou: review python handling
Product:	Gentoo Linux	Reporter:	Mart Raudsepp <leio>
Component:	Current packages	Assignee:	Matthew Turnbull <sparky>
Status:	RESOLVED FIXED
Severity:	normal	CC:	chrisadr, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=629046 https://github.com/gentoo/gentoo/pull/19233
Whiteboard:
Package list:		Runtime testing required:	---

Description Mart Raudsepp gentoo-dev

2017-08-27 21:31:21 UTC

I'm not sure python-r1.eclass is appropriate here. Or even if something does use the modules, besides /usr/bin/caribou-preferences, then things are messy inside the package itself:

/usr/bin/caribou-preferences is a caribou-self-coded shell wrapper that with PYTHON_TARGETS="python2_7 python3_4 python3_6" ends up hardcoding a call to /usr/bin/python3.6 specifically; thus more like python-single-r1 + potentially fixing that shellscript to honor the single choice properly, if it happens to select latest somehow on its own.

Comment 1 Mart Raudsepp gentoo-dev

2017-08-27 21:36:14 UTC

At least after removing python3_6, it ends up with python3.4 calling shellscript instead. Still wrong, but at least it isn't calling things for a python version package manager isn't ensuring dependencies for. Looks like the shell script will use the python version that happens to get src_install called for last by python-r1.eclass

Comment 2 Larry the Git Cow gentoo-dev

2021-03-01 13:02:52 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=265cdd847717520d14fe94e5798ca64c9fff23b3

commit 265cdd847717520d14fe94e5798ca64c9fff23b3
Author:     Matthew S. Turnbull <sparky@bluefang-logic.com>
AuthorDate: 2021-01-25 06:03:07 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-01 13:02:43 +0000

    app-accessibility/caribou: Package clean-up
    
    * Update to EAPI7.
    
    * Convert to python-single-r1, as it doesn't look
    like it actually installs python bindings. Also
    remove env setup handling from launcher scripts.
    
    * Drop GTK-2 support.
    
    Closes: https://bugs.gentoo.org/629108
    Closes: https://bugs.gentoo.org/642582
    Bug: https://bugs.gentoo.org/772950
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Matthew S. Turnbull <sparky@bluefang-logic.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-accessibility/caribou/caribou-0.4.21-r3.ebuild | 96 ++++++++++++++++++++++
 .../caribou/files/caribou-fix-python-env.patch     | 58 +++++++++++++
 2 files changed, 154 insertions(+)