Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 628228

Summary: dev-util/kscope-1.9.4-r2 with x11-libs/qscintilla-2.10 - cannot find -lqscintilla2
Product: Gentoo Linux Reporter: Sławomir Nizio <slawomir.nizio>
Component: Current packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED WONTFIX    
Severity: normal CC: treecleaner
Priority: Normal Keywords: PATCH, PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard: Masked for removal on 2017-10-11
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 628304    
Attachments: makes it build

Description Sławomir Nizio 2017-08-18 20:37:22 UTC
Created attachment 489546 [details, diff]
makes it build

diff --git a/dev-util/kscope/kscope-1.9.4-r2.ebuild b/dev-util/kscope/kscope-1.9.4-r2.ebuild
index a1d378341..bdd8e35f0 100644
--- a/dev-util/kscope/kscope-1.9.4-r2.ebuild
+++ b/dev-util/kscope/kscope-1.9.4-r2.ebuild
@@ -16,7 +16,7 @@ IUSE=""
 
 RDEPEND="dev-qt/qtcore:4
        dev-qt/qtgui:4
-       x11-libs/qscintilla:=[qt4(-)]"
+       >=x11-libs/qscintilla-2.10:=[qt4(-)]"
 DEPEND="${RDEPEND}"
 
 DOCS="ChangeLog"
@@ -33,5 +33,7 @@ src_prepare() {
        # fix build failure with parallel make
        echo "CONFIG += ordered" >> kscope.pro
 
-       epatch "${FILESDIR}/${P}"-{actions,underlinking}.patch
+       epatch \
+               "${FILESDIR}/${P}"-{actions,underlinking}.patch \
+               "${FILESDIR}"/qscintilla-2.10.patch
 }
Comment 1 Andreas Sturmlechner gentoo-dev 2017-08-19 12:06:21 UTC
Thanks for your contribution, can you create a version of the patch that does not raise dependency on qscintilla and requires us to mask kscope as well?
Comment 2 Sławomir Nizio 2017-08-19 15:56:43 UTC
Thanks for creating the tracker bug. Note that with a single exception (app-editors/qwriter; and dev-vcs/hgview to check qscintilla-python), I didn't make a runtime test of the packages, but I checked that if they had qscintilla*.so in any NEEDED, they have it still after updating qscintilla and rebuilding them. 

(This was to reduce the risk of a silent "functionality downgrade" like in the case of sci-mathematics/octave - bug 617024.)

Plus I didn't make sure to handle all packages that depends on scintilla (but looks like only dev-db/tora is left to check).

(In reply to Andreas Sturmlechner from comment #1)
> Thanks for your contribution, can you create a version of the patch that
> does not raise dependency on qscintilla and requires us to mask kscope as
> well?

OK. I don't know much about qmake, but from what I saw so far, it doesn't provide a clean way to do it. What do you think about 'has_version xxxx && epatch'?
Comment 3 Michael Palimaka (kensington) gentoo-dev 2017-09-11 13:28:50 UTC
Relies on Qt 4 and has self-declared dead upstream. Time to go?
Comment 4 Michael Palimaka (kensington) gentoo-dev 2017-10-12 12:26:20 UTC
Package removed.