Bug 627572

Summary:	dev-util/sysdig-0.17.0: userspace/libsinsp/marathon_http.cpp: fatal error: curl /curlbuild.h: No such file or directory
Product:	Gentoo Linux	Reporter:	Thomas Deutschmann (RETIRED) <whissi>
Component:	Current packages	Assignee:	Michał Górny <mgorny>
Status:	RESOLVED FIXED
Severity:	normal	CC:	holger, proteuss, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/draios/sysdig/issues/895
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log Patch to remove curlbuild references

Description Thomas Deutschmann (RETIRED) gentoo-dev

2017-08-11 22:17:56 UTC

Created attachment 488622 [details]
build.log

[...]
[54/88] /usr/bin/x86_64-pc-linux-gnu-g++ -DHAS_CAPTURE -DK8S_DISABLE_THREAD -DPLATFORM_NAME=\"Linux\" -I/var/tmp/portage
/dev-util/sysdig-0.17.0/work/sysdig-0.17.0/userspace/libsinsp/. -I/var/tmp/portage/dev-util/sysdig-0.17.0/work/sysdig-0.
17.0/userspace/libsinsp/../../common -I/var/tmp/portage/dev-util/sysdig-0.17.0/work/sysdig-0.17.0/userspace/libsinsp/../
libscap -I/usr/include/jsoncpp -I/usr/include/luajit-2.0  -DNDEBUG -O2 -pipe -march=native -mtune=native -Wall  --std=c+
+0x -MD -MT userspace/libsinsp/CMakeFiles/sinsp.dir/marathon_http.cpp.o -MF userspace/libsinsp/CMakeFiles/sinsp.dir/mara
thon_http.cpp.o.d -o userspace/libsinsp/CMakeFiles/sinsp.dir/marathon_http.cpp.o -c /var/tmp/portage/dev-util/sysdig-0.1
7.0/work/sysdig-0.17.0/userspace/libsinsp/marathon_http.cpp
FAILED: userspace/libsinsp/CMakeFiles/sinsp.dir/marathon_http.cpp.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DHAS_CAPTURE -DK8S_DISABLE_THREAD -DPLATFORM_NAME=\"Linux\" -I/var/tmp/portage/dev-uti
l/sysdig-0.17.0/work/sysdig-0.17.0/userspace/libsinsp/. -I/var/tmp/portage/dev-util/sysdig-0.17.0/work/sysdig-0.17.0/use
rspace/libsinsp/../../common -I/var/tmp/portage/dev-util/sysdig-0.17.0/work/sysdig-0.17.0/userspace/libsinsp/../libscap
-I/usr/include/jsoncpp -I/usr/include/luajit-2.0  -DNDEBUG -O2 -pipe -march=native -mtune=native -Wall  --std=c++0x -MD
-MT userspace/libsinsp/CMakeFiles/sinsp.dir/marathon_http.cpp.o -MF userspace/libsinsp/CMakeFiles/sinsp.dir/marathon_htt
p.cpp.o.d -o userspace/libsinsp/CMakeFiles/sinsp.dir/marathon_http.cpp.o -c /var/tmp/portage/dev-util/sysdig-0.17.0/work
/sysdig-0.17.0/userspace/libsinsp/marathon_http.cpp
/var/tmp/portage/dev-util/sysdig-0.17.0/work/sysdig-0.17.0/userspace/libsinsp/marathon_http.cpp:10:28: fatal error: curl
/curlbuild.h: No such file or directory
compilation terminated.


Probably related to the following net-misc/curl change: https://github.com/curl/curl/commit/73a2fcea0b4adea6ba342cd7ed1149782c214ae3

Comment 1 Andreas Proteus 2017-08-12 13:29:04 UTC

Same problem here.
To compile the sysdig module I masked =netmisc/curl-7.55.0

Comment 2 Sam Stone 2017-08-13 21:13:30 UTC

I encountered the same bug here

Comment 3 Holger Hoffstätte 2017-08-14 09:30:50 UTC

I already commented on the upstream bug, but for reference it's not
necessary to hardcode the curl version; all sysdig needs to do is stick
with public APIs instead of including private headers.

Comment 4 Holger Hoffstätte 2017-08-14 09:32:01 UTC

Created attachment 488884 [details, diff]
Patch to remove curlbuild references

This patch will let sysdig build with any curl version.

Comment 5 Andreas Proteus 2017-08-14 10:47:34 UTC

The patch worked here.
So the curlbuild.h header is not needed after all.
Thank you.

Comment 6 Larry the Git Cow gentoo-dev

2017-09-11 20:16:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b22e8f9a974f682f9b35d5a54ed21fc30f8e94e6

commit b22e8f9a974f682f9b35d5a54ed21fc30f8e94e6
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-09-11 20:13:37 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2017-09-11 20:16:03 +0000

    dev-util/sysdig: Backport net-misc/curl-7.55.0+ build fix
    
    Closes: https://bugs.gentoo.org/627572

 .../sysdig/files/sysdig-0.17.0-curlbuild.h.patch   | 53 ++++++++++++++++++++++
 ...ysdig-0.17.0.ebuild => sysdig-0.17.0-r1.ebuild} |  8 +++-
 2 files changed, 60 insertions(+), 1 deletion(-)

Comment 7 Larry the Git Cow gentoo-dev

2017-09-11 20:24:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/sync/gentoo.git/commit/?id=b22e8f9a974f682f9b35d5a54ed21fc30f8e94e6

commit b22e8f9a974f682f9b35d5a54ed21fc30f8e94e6
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-09-11 20:13:37 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2017-09-11 20:16:03 +0000

    dev-util/sysdig: Backport net-misc/curl-7.55.0+ build fix
    
    Closes: https://bugs.gentoo.org/627572

 .../sysdig/files/sysdig-0.17.0-curlbuild.h.patch   | 53 ++++++++++++++++++++++
 ...ysdig-0.17.0.ebuild => sysdig-0.17.0-r1.ebuild} |  8 +++-
 2 files changed, 60 insertions(+), 1 deletion(-)