Summary: | www-client/firefox-55.0 won't build with sys-devel/clang-4.0.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Eric Siegel <eric> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | evanjsx, luke |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info
Add errno.h to list of includes |
Description
Eric Siegel
2017-08-11 03:31:21 UTC
(In reply to Eric Siegel from comment #0) > This error did not occur with firefox-54.0.1, that compiled just fine with > clang and lld. ^^ Fixed somed typos Created attachment 488734 [details, diff]
Add errno.h to list of includes
SandboxOpenedFiles.cpp, which was not present in firefox-54.0.1, was missing the following line:
#include <errno.h>
Please test with firefox-56.0_beta9 from mozilla overlay. If you can still reproduce please feel free to reopen. Is there a difference between the www-client/firefox-57.0 ebuilds in the portage tree and the mozilla overlay? I build firefox-58 *without* the mozilla overlay and my suggested patch was still needed to allow it to build with clang-5.0.0. hmm, I had a quick look at the file you had to patch, and the errno.h is now included. Could you try again with 59.0, as it will hit the tree in the next time? Wanted to test it with arm, but there are problems with src_configure, before even starting to compile. I have the same error with thunderbird-60.2.1 and the patch fixes this issue *** This bug has been marked as a duplicate of bug 667096 *** (In reply to Lionel MANNONE from comment #6) > I have the same error with thunderbird-60.2.1 and the patch fixes this issue jfyi, this is now available via https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af6aa45d9abaef36b72811c9141beeda3f4f59d0 |