Summary: | libtool-1.5.2-r5 failes maketests - sh.test failed - nested quotes in ltmain.sh | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Daniel Black (RETIRED) <dragonheart> |
Component: | Current packages | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | CC: | sascha-gentoo-bugzilla, wjmcqueen |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://lists.gnu.org/archive/html/bug-libtool/2004-08/msg00119.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Daniel Black (RETIRED)
2004-09-03 01:16:15 UTC
fixed upstream in after 1.9b Any chance of getting the fix backported to 1.5.2? Given this bug, 1.5.2 is listed as stable for what reason? I admit, stone-cold down is very stable, but it lacks the utility that most of us associate with the word 'stable'. The bug resolution on this is incorrect/misleading/disingenuous. It's not an upstream issue - the errors (nested quotes) are introduced by the Gentoo patch sys-devel/libtool/files/1.4.3/libtool-1.4.2-portage.patch. This patch is where the nested quoting comes in. I can't convince myself that the double quotes are necessary, or even that they have any effect, but perhaps there's some unusual circumstance in which they do. They may even be actually incorrect. For example, here's the first occurrence: eval mynewdependency_lib="`echo "$libdir/$name" |sed -e "s:$D::g" -e 's://:/:g'`" And here's a test script and results, with a simplified version of that line in ltmain.in (=> ltmain.sh.in): bash-2.05b$ cat shtst #!/bin/bash echo "$1/$2 - $3" echo "\ ----start eval mynewdependency_lib="`echo "$1/$2" |sed -e "s:$3::g" -e 's://:/:g'`" eval mynewdependency_lib=`echo "$1/$2" |sed -e "s:$3::g" -e 's://:/:g'` ----end " bash-2.05b$ ./shtst "/a b/c d" "e f" "/a b" /a b/c d/e f - /a b ----start eval mynewdependency_lib=/c d/e f eval mynewdependency_lib=/c d/e f ----end bash-2.05b$ and as we can see, the first occurrence (with the nested quotes) ends up with spaces collapsing (since there's already quotes around the whole thing, which makes the first quote in the line an end-quote). The second retains the spacing. Without spaces, of course, there's no difference. As an aside, perhaps the "$D" in the original line could do with a preceding ^, to anchor it to the start of the path. |