| Summary: | media-gfx/llgal-0.13.18 : * The source directory /var/tmp/portage/media-gfx/llgal-0.13.18/work/llgal-0.13.18 doesn t exist | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | David Seifert <soap> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aballier, david, graphics+disabled |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 media-gfx:llgal-0.13.18:20170730-203308.log Patch for lltag to replace gna.org (tested and built successfully) Patch for llgal to replace gna.org (tested and built successfully) |
||
Created attachment 487434 [details]
emerge-info.txt
Created attachment 487436 [details]
emerge-history.txt
Created attachment 487438 [details]
environment
Created attachment 487440 [details]
etc.portage.tbz2
Created attachment 487442 [details]
media-gfx:llgal-0.13.18:20170730-203308.log
When merging pull request, especially those for packages with a dedicated maintainer, I would expect said maintainer to be contacted first and changes to be at the very least build tested. Commits on lltag/llgal have been reverted for now. Please fix the proper way. Plus, author does not even have a bugzila account. Created attachment 487546 [details, diff]
Patch for lltag to replace gna.org (tested and built successfully)
Created attachment 487548 [details, diff]
Patch for llgal to replace gna.org (tested and built successfully)
Sorry for the bad patches before, I wasn't aware that GitHub adds the organisation name in front of the typical ${PN} folder that is at the root of the compressed source file.
I've attached two revised patches that modify the source directory (S=) to factor in the GitHub organisation name being added to the extracted source path.
With the lltag and llgal patches attached, I was able to successfully build both packages without issue.
Oops, well it's not adding the GitHub organisation name, but it still has a duplicate ${PN} in the name of the root directory within the compressed source tarball. I'll be very mindful from now on about checking the source files have the same contents when a project moves between hosting providers/updates their official download links.
(In reply to David Hicks from comment #7) > Created attachment 487546 [details, diff] [details, diff] > Patch for lltag to replace gna.org (tested and built successfully) (In reply to David Hicks from comment #8) > Created attachment 487548 [details, diff] [details, diff] > Patch for llgal to replace gna.org (tested and built successfully) Thanks. As the digests are changing, could you please attach 'diff -uNr' of both the old and new tarballs unpacked ? I've just checked llgal diffs and the archives are quite different--the GitHub archives contain a bunch of other files usually stripped from the release build.
We should probably just be using the following for versions <= 0.13.18 that are already in the tree:
SRC_URI="mirror://gentoo/${P}.tar.gz"
Recently there was a new release 0.13.19 that is only available via GitHub[1], so the new (and working) GitHub release archives could be used for versions >= 0.13.19.
The same would apply to lltag which also recently received a new release 0.14.6 which is only available via GitHub[2].
[1] https://github.com/bgoglin/llgal/releases/tag/llgal-0.13.19
[2] https://github.com/bgoglin/lltag/releases/tag/lltag-0.14.6
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=720cc8c91b2df42314c691fb90fa0ec1f23050fa commit 720cc8c91b2df42314c691fb90fa0ec1f23050fa Author: David Seifert <soap@gentoo.org> AuthorDate: 2018-12-01 15:12:16 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2018-12-01 15:13:07 +0000 media-gfx/llgal: Version bump to 0.13.19 Closes: https://bugs.gentoo.org/626712 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: David Seifert <soap@gentoo.org> media-gfx/llgal/Manifest | 1 + media-gfx/llgal/llgal-0.13.19.ebuild | 46 ++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) |
>>> Source unpacked in /var/tmp/portage/media-gfx/llgal-0.13.18/work * ERROR: media-gfx/llgal-0.13.18::gentoo failed (prepare phase): * The source directory '/var/tmp/portage/media-gfx/llgal-0.13.18/work/llgal-0.13.18' doesn't exist * * Call stack: * ebuild.sh, line 767: Called __ebuild_main 'prepare' ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 13.0-desktop-gnome_20170723-192245 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-6.3.0 * Available Python interpreters, in order of preference: [1] python3.4 [2] python2.7 (fallback) [3] pypy3 (fallback) Available Ruby profiles: [1] ruby21 (with Rubygems) [2] ruby22 (with Rubygems) * java-config: The following VMs are available for generation-2: *) IcedTea JDK 3.5.0 [icedtea-bin-8] Available Java Virtual Machines: [1] icedtea-bin-8 system-vm emerge -qpv media-gfx/llgal [ebuild N ] media-gfx/llgal-0.13.18 USE="exif" LINGUAS="-de -en -fr -it"