Bug 625574 – >=sys-apps/ucspi-ssl-0.97 fails compile: fatal error: openssl/ec.h: No such file or directory

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Kent Fredric (IRC: kent\n) (RETIRED) 2017-07-18 23:04:58 UTC]

Created attachment 485618 [details]
build.log

All versions 0.97 through 0.99 fail, for reasons that I assume are related to newer OpenSSL

> portageq match / dev-libs/openssl
dev-libs/openssl-1.0.2k


0.97:


./compile sslclient.c                                      
In file included from sslclient.c:11:0:              
ucspissl.h:13:24: fatal error: openssl/ec.h: No such file or directory                                                                     
compilation terminated.                                         
make: *** [Makefile:701: sslclient.o] Error 1                 


0.98b:

./compile sslclient.c
cc -march=native -mtune=native -O2 -pipe   -c -o remoteinfo6.o remoteinfo6.c
cc -march=native -mtune=native -O2 -pipe   -c -o timeoutconn6.o timeoutconn6.c
rm -f makelib
./compile ssl_ca.c
sh print-ar.sh > makelib
chmod 755 makelib
./compile ssl_cca.c
In file included from sslclient.c:11:0:
ucspissl.h:14:24: fatal error: openssl/ec.h: No such file or directory
compilation terminated.
make: *** [Makefile:703: sslclient.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from ssl_ca.c:1:0:
ucspissl.h:14:24: fatal error: openssl/ec.h: No such file or directory
compilation terminated.
make: *** [Makefile:627: ssl_ca.o] Error 1
In file included from ssl_cca.c:1:0:
ucspissl.h:14:24: fatal error: openssl/ec.h: No such file or directory
compilation terminated.
make: *** [Makefile:631: ssl_cca.o] Error 1


0.99:

./compile ssl_cca.c
In file included from sslclient.c:11:0:
ucspissl.h:14:24: fatal error: openssl/ec.h: No such file or directory
compilation terminated.
make: *** [Makefile:703: sslclient.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from ssl_ca.c:1:0:
ucspissl.h:14:24: fatal error: openssl/ec.h: No such file or directory
compilation terminated.
make: *** [Makefile:627: ssl_ca.o] Error 1
In file included from ssl_cca.c:1:0:
ucspissl.h:14:24: fatal error: openssl/ec.h: No such file or directory
compilation terminated.

[Comment 1 Alex Efros 2017-07-19 06:59:50 UTC]

Show please your USE flags for openssl and try to re-emerge it. I've the same versions and don't have this issue:

[ebuild   R    ] dev-libs/openssl-1.0.2k::gentoo  USE="asm sslv3 tls-heartbeat zlib -bindist -gmp -kerberos -rfc3779 -sctp -sslv2 -static-libs {-test} -vanilla" ABI_X86="32 (64) (-x32)" CPU_FLAGS_X86="(sse2)" 0 KiB

$ qlist openssl | grep 'ec[.]h'
/usr/include/openssl/ec.h

[Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) 2017-07-19 19:55:56 UTC]

Only disinguishing flag I see is bindist.

[ebuild   R    ] dev-libs/openssl-1.0.2k::gentoo  USE="asm bindist sslv3 tls-heartbeat zlib -gmp -kerberos -rfc3779 -sctp -sslv2 -static-libs {-test} -vanilla" CPU_FLAGS_X86="(sse2)" 0 KiB



> qlist openssl | grep "ec[.]h"
>

Which is relevant, look at openssl's.s src_configure code:

      $(use_ssl !bindist ec) \

Its like, the only place bindist is used. 

 local:bindist:dev-libs/openssl: Disable EC algorithms (as they seem to be patented) -- note: changes the ABI


So it seems ucspi-ssl now requires dev-libs/openssl[-bindist]

[Comment 3 Alex Efros 2018-01-21 16:48:59 UTC]

(In reply to Kent Fredric (IRC: kent\n) from comment #2)
> So it seems ucspi-ssl now requires dev-libs/openssl[-bindist]

It looks like ucspi-ssl is able to compile with bindist, but this require some extra patching. I'm going to release ucspi-ssl-0.99d with USE=bindist support.

It's hard for me to test this change - attempt to `USE=bindist emerge openssl` break a lot of packages, so the best I was able to do is temporary `USE=bindist emerge --nodeps openssl` - but this let me to only test compilation of ucspi-ssl and I didn't tested is it actually works.

Can you please test it yourself (I'll attach ebuild now)?

[Comment 4 Alex Efros 2018-01-21 16:50:02 UTC]

Created attachment 515718 [details]
ucspi-ssl-0.99d.ebuild

[Comment 5 Alex Efros 2019-03-02 01:53:14 UTC]

Fixed in 0.99e (PR https://github.com/gentoo/gentoo/pull/11177), waiting for merge…

[Comment 6 Larry the Git Cow 2019-05-21 00:29:36 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71b29a42b07e8af16132a8a59f306727c197960f

commit 71b29a42b07e8af16132a8a59f306727c197960f
Author:     Alex Efros <[e-mail]>
AuthorDate: 2019-02-28 18:02:37 +0000
Commit:     Stefan Strogin <[e-mail]>
CommitDate: 2019-05-21 00:27:20 +0000

    sys-apps/ucspi-ssl: Version bump to 0.99e
    
    Add USE=libressl; EAPI=7.
    
    Closes: https://bugs.gentoo.org/678930
    Closes: https://bugs.gentoo.org/645252
    Closes: https://bugs.gentoo.org/625574
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Aleksandr Efros <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/11177
    Signed-off-by: Stefan Strogin <[e-mail]>

 sys-apps/ucspi-ssl/Manifest               |  1 +
 sys-apps/ucspi-ssl/metadata.xml           |  3 ++
 sys-apps/ucspi-ssl/ucspi-ssl-0.99e.ebuild | 62 +++++++++++++++++++++++++++++++
 3 files changed, 66 insertions(+)