Bug 625138

Summary:	net-fs/samba-4.5.10[-ads,cluster] - ../source3/winbindd/idmap_ad_nss.c:357:13: error: incompatible types when assigning to type ‘ADS_STATUS’ from type ‘int’
Product:	Gentoo Linux	Reporter:	Ben Kohler <bkohler>
Component:	Current packages	Assignee:	Gentoo's SAMBA Team <samba>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bkohler
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugzilla.samba.org/show_bug.cgi?id=12750
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	gzipped build log

Description Ben Kohler gentoo-dev

2017-07-14 18:40:47 UTC

If you enable USE=cluster on samba-4.5.10 without also enabling USE=ads, it will fail to compile.  See the upstream report where he says that "idmap_ad" cannot be enabled if --without-ads is set, and really this makes sense.

I think the easiest fix would be to add "cluster? ( ads )" in REQUIRED_USE, but I'm not familiar with what USE=cluster does or implies in this context.

Thanks!

Comment 1 Ben Kohler gentoo-dev

2017-07-14 18:44:33 UTC

Created attachment 484636 [details]
gzipped build log

Comment 2 Rolf Eike Beer archtester

2018-03-14 17:31:18 UTC

Same for 4.5.16.

Comment 3 Larry the Git Cow gentoo-dev

2018-03-15 08:34:08 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4117767bbc179bfd13c0268b08984fe3dfddcf06

commit 4117767bbc179bfd13c0268b08984fe3dfddcf06
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-03-15 08:33:33 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-03-15 08:34:02 +0000

    net-fs/samba: USE="cluster" requires USE="ads"
    
    Closes: https://bugs.gentoo.org/625138
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 net-fs/samba/samba-4.5.15.ebuild | 7 +++++--
 net-fs/samba/samba-4.5.16.ebuild | 4 +++-
 net-fs/samba/samba-4.6.14.ebuild | 9 ++++++---
 net-fs/samba/samba-4.7.6.ebuild  | 9 ++++++---
 net-fs/samba/samba-4.8.0.ebuild  | 1 +
 5 files changed, 21 insertions(+), 9 deletions(-)