| Summary: | bmp-wma ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | will |
| Component: | New packages | Assignee: | Tony Vroon (RETIRED) <chainsaw> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | EBUILD |
| Priority: | High | ||
| Version: | 2004.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
The ebuild
A new ebuild bmp-wma-0.1.0.ebuild 0.1.0-functions-above-caller.patch 0.1.0-includes.patch bmp-wma-0.1.1.ebuild bmp-wma-0.1.1.ebuild |
||
|
Description
will
2004-08-30 08:58:20 UTC
Created attachment 38512 [details]
The ebuild
I have a bmp-wma ebuild ready that installs to the right location (please add an original description). Consider using doexe to move the library in place instead of using make install and then moving files around. The src_unpack is unnecessary, as this what portage does by default. Please remove that. The DEPEND line is a problem, though. That will break. I can't merge an ebuild like this. I will attach my ebuild in a few hours when I'm back home, and then we'll ask for testers. Have you tested the resulting plugin? I can get it to build using GCC 3.4, however it makes BMP segfault when a .wma is opened. Please address these concerns then reopen the bug. Also, what version of beep-media-player was this tested against? The current 0.9.7_rc2 version in portage will require a patch to the includes. I have that, I will attach it here as well. Created attachment 38678 [details]
A new ebuild
Here is an ebuild that will hopefully address the above issues. I have built it
against the most recent version in portage with gcc 3.4. It segfaults when I
try to play anything, but I don't think that this is the ebuilds fault, because
it crashes when I build it manually.
reopening Created attachment 38686 [details]
bmp-wma-0.1.0.ebuild
The second attempt is indeed a lot better, thank you for your contribution.
Here is the ebuild that I've written so far.
I have also included the two patches I needed to have things build succesfully
with BMP 0.9.7 RC2 & GCC 3.4.1
I have contacted the plugin author in an attempt to resolve the segfault
occuring with the plugin. The included wma123 tool works correctly, but there
is not much sense in packaging a defective plugin.
Created attachment 38687 [details, diff]
0.1.0-functions-above-caller.patch
Created attachment 38688 [details, diff]
0.1.0-includes.patch
I am in contact with the plugin author, and have already received some feedback. I will submit a backtrace, and I have good hopes that the segfault will be resolved in the next few days. For now, the wma123 tool is already usable. Please test that with as many .wma files as you can so bugs can be submitted if you can make it fall over. Still working on this, a backtrace has been submitted, awaiting feedback from plugin author. This plugin is defective and can not be packaged until a new version is released by it's author. A new version has been released which works on beep-media-player 0.9.7. I have made an ebuild for it. Removing the bug reference, no longer applies. Created attachment 46570 [details]
bmp-wma-0.1.1.ebuild
Here is the ebuild
Addition to ebuild; enable x86-specific optimizations and respond to wma123 USE-flag for optional command-line wma123 player. The new version does indeed work correctly. Created attachment 46571 [details]
bmp-wma-0.1.1.ebuild
Ebuild based on yours, src_compile added.
Okay, last changes done after adding in src_compile; adjusted header line to:
$Header: $ (missing space)
Removed src_unpack, it only does unpack ${A}, this is the default.
Thank you for your report. Please give the ebuild two hours to propagate before you sync.
|
